MM-59373: Respecting name display preference in boards #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajat-Dabade
added
2: Dev Review
harshilsharma63
requested changes
Oct 10, 2024
| className='comment-text' | ||
| dangerouslySetInnerHTML={{__html: html}} | ||
| /> | ||
| <Provider store={(window as any).store}> |
There was a problem hiding this comment.
Can you share why do we need to create a store provider here? It does't look right.
webapp/src/store/teams.ts
Outdated
| @@ -87,3 +93,19 @@ export const getCurrentTeamId = (state: RootState): string => state.teams.curren | |||
| export const getCurrentTeam = (state: RootState): Team|null => state.teams.current | |||
| export const getFirstTeam = (state: RootState): Team|null => state.teams.allTeams[0] | |||
| export const getAllTeams = (state: RootState): Team[] => state.teams.allTeams | |||
|
|
|||
|
|
|||
| export const getChannelsNameMapInTeam: (state: GlobalState, teamId: string) => Record<string, Channel> = createSelector( | |||
There was a problem hiding this comment.
This can be removed as its not being used. We're using the selector directly from MM redux package.
| // Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved. | ||
| // See LICENSE.txt for license information. | ||
|
|
||
| export const { |
There was a problem hiding this comment.
You need to defined the types like how its done in user survey plugin for example - https://github.com/mattermost/mattermost-plugin-user-survey/blob/29685cc4d7ca0a2e1de196c23f6165caeacaf1b4/webapp/src/types/mattermost-webapp/index.d.ts#L10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support to respect name display preference from channel to boards.
Ticket Link
https://mattermost.atlassian.net/browse/MM-59373