Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-819]: Added testcases for multiple functions in command_hooks.go file #58

Merged
merged 10 commits into from
Oct 10, 2024

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

Added test cases for multiple functions in command_hooks.go file

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Oct 7, 2024
@Kshitij-Katiyar Kshitij-Katiyar marked this pull request as draft October 7, 2024 10:20
@Kshitij-Katiyar Kshitij-Katiyar marked this pull request as ready for review October 7, 2024 11:03
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Oct 7, 2024
@wiggin77
Copy link
Member

wiggin77 commented Oct 7, 2024

/update-branch

@wiggin77 wiggin77 self-requested a review October 7, 2024 18:59
@wiggin77
Copy link
Member

wiggin77 commented Oct 7, 2024

@Kshitij-Katiyar some CI failures created when previous PR was merged and updated here.

@Kshitij-Katiyar
Copy link
Contributor Author

Hey @wiggin77,
I fixed the CI. It was an issue due to the duplicate function name in the same package after merging a different PR.

server/command_hooks_test.go Outdated Show resolved Hide resolved
server/command_hooks_test.go Show resolved Hide resolved
@raghavaggarwal2308 raghavaggarwal2308 merged commit 3e5043f into master Oct 10, 2024
4 checks passed
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.2 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants