Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mm-507] Add support for DM subscriptions based on "watching" an issue in Jira (#507) #792
[mm-507] Add support for DM subscriptions based on "watching" an issue in Jira (#507) #792
Changes from 1 commit
397c5fd
626719d
d046db9
2325e8e
899017f
8b6b28b
e17c0cf
74e9b69
51f0fb2
ece396d
dd55c1d
e3e5502
29e4ed3
0b02444
f980d21
9cc2e4d
028ae19
23d01fc
e1e669d
702c079
24eaa07
73373d1
29a812d
9d72ffe
ae2b7f2
65f0e66
681eff5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this
*bool
, and use a similar strategy as described here? I'd like users to be able to get these notifications without enabling this.@DHaussermann Maybe we should be clear about why the user got the notification, and note that they can opt-out of this feature? If we have it off by default, I think it won't be discovered by most users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister I've pushed a new commit for this change, could you please check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DHaussermann @aaronrothschild Please see my comment above
If the current settings for a user has notifications "on" before this PR, should we assume the user also wants reporter and watcher notifications when we introduce the changes from this PR? Should we tell the user how to change their settings? Maybe we only tell them how to change their settings the next time they get a notification. We tell them how to change their settings, and don't remind them again.
Should we tell the user the reason they are getting a notification? It would be one of the following reasons:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this method need to be defined on
*webhook
? Is something similar already implemented on the*Plugin
struct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vicky-demansol I don't think this method needs to be defined on
*webhook
. Can we just call an existing method to fetch the connection instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens here when the
wh.notifications
array is empty andmessage
is blank? How do we access the message to create a notification? Maybe we need to call a function to generate a message for this webhook call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister I've pushed a new commit for this change, could you please check it?
I put the same logic with
func PostNotifications
mattermost-plugin-jira/server/webhook.go
Lines 100 to 103 in 6678cae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #792 (comment)