[GH-507,699] Add Support for DM subscriptions for watchers and reporter #872

Kshitij-Katiyar · 2022-09-22T10:45:58Z

Summary

In order to get a DM notification from the Jira plugin, the user has to meet certain criteria like being assigned or mentioned. But now even if a user is a reporter or watching that issue will also get a DM notification.
This PR contains all the changes from Pr #840 So this PR alone is enough to fix this issue so we can close Pr #840 afterward.

Issue

…#1) * [MI-2088]:Add Support for DM subscriptions for watchers and reporters * [MI-2088]: Review Fixes 1. Improved the name of certain variable 2. Improved spacing * [MI-2088]:Revieww fixes 1.Changes the names of few variables 2.Improved code complexity * [MI-2088]: Review fixes done 1.Changed the name of few variables * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>

mattermod · 2022-09-22T10:46:02Z

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

javaguirre

Hi! I'm Javi, from Mattermost (first week), I have a couple of comments, let me know what you think!

Thank you for the hard work! This is a tricky one! :-)

server/settings.go

server/webhook.go

javaguirre · 2022-09-27T08:01:06Z

@Kshitij-Katiyar @Nityanand13 This is what I mean, I think changing the way we store the data in the struct would make us do much less code and this code would be easier to test.

https://replit.com/@javaguirre/GH-507699#main.go

Let me know what you think!

javaguirre

Let me know when you have an opinion on my approach! Thank you! :-)

Nityanand13 · 2022-09-29T08:37:39Z

@javaguirre Sorry for the late reply. Your approach seems good and now I am implementing the same.

javaguirre · 2022-09-29T08:38:19Z

Thank you @Nityanand13 ! Let me know if you need anything! 👍

…struct so that the code can be easily tested (#6) * [MI-2088]:Add Support for DM subscriptions for watchers and reporters * [MI-2088]: Review Fixes 1. Improved the name of certain variable 2. Improved spacing * [MI-2088]:Revieww fixes 1.Changes the names of few variables 2.Improved code complexity * [MI-2088]: Review fixes done 1.Changed the name of few variables * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:Review fixes done 1.Changed the way to store assignee, mention, reporter and watching in struct so that the code can be easily tested * [MI-2088]: Review fixes done 1. Changed the name of various variables 2. Used constants everywhere Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>

javaguirre

Thank you! I really like the changes, I think it's much cleaner now.

I have some details to finish, let me know what you think!

server/user.go

server/issue.go

javaguirre · 2022-10-04T07:20:17Z

Could you post a video on how to use this new change? Something like this so it's easier to QA.

#863 (comment)

Thank you!

Nityanand13 · 2022-10-05T11:04:06Z

Could you post a video on how to use this new change? Something like this so it's easier to QA.

#863 (comment)

Thank you!

Vedio link for this PR:

javaguirre · 2022-10-06T08:13:11Z

Thank you very much @Nityanand13 ! Let me know when testing is done @Kshitij-Katiyar . 👍

javaguirre · 2022-10-06T08:16:56Z

@Nityanand13 Can't open the videos in any of the PRs, can you check the extension of the files and tell me what kind of video is so I can open it? Also If I could already open it online would be nice, with something like loom or whatever video Drive supports.

Thank you very much!

Nityanand13 · 2022-10-06T09:24:59Z

@Nityanand13 Can't open the videos in any of the PRs, can you check the extension of the files and tell me what kind of video is so I can open it? Also If I could already open it online would be nice, with something like loom or whatever video Drive supports.

Thank you very much!

Vedio link for this PR:

Add_Support_for_DM_subscriptions_for_watchers.webm
Add_Support_for_DM_subscriptions_for_reporter.webm

javaguirre · 2022-10-11T10:02:25Z

The CI is failing @Nityanand13 , let me know if you can check it out! Thank you!

javaguirre · 2022-10-13T10:14:28Z

I see the changes are in the other PR

* [MI-2088]:Add Support for DM subscriptions for watchers and reporters * [MI-2088]: Review Fixes 1. Improved the name of certain variable 2. Improved spacing * [MI-2088]:Revieww fixes 1.Changes the names of few variables 2.Improved code complexity * [MI-2088]: Review fixes done 1.Changed the name of few variables * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:Review fixes done 1.Changed the way to store assignee, mention, reporter and watching in struct so that the code can be easily tested * [MI-2088]: Review fixes done 1. Changed the name of various variables 2. Used constants everywhere * [MI-2088]: Review fixes done 1. Added Test cases 2. Used booleans instead of pointer in RolesForDMNotification * [MI-2088]: Review fixes done 1. Modified test cases * [MI-2088]: Review fixes done 1. Self reviewed * [MI-2088]: Review fixes done 1. Changed the formatting 2. Changed the name of few variables 3. Improved code quality * [MI-2088]: Fixes CI errors * [MI-2088]: Review fixes done 1. Improved code quality * [MI-2088]: Review fixes done 1. Improved code quality * [MI-2088]: Review fixes done 1. Improved code quality Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>

mickmister

Great work on this @Kshitij-Katiyar! have a just a few questions here, and a request to remove changes unrelated to the purpose of the PR. Please let me know what you think 👍

mickmister · 2022-10-17T02:36:07Z

server/issue.go

-				Value: issue.ID,
-				Label: issue.Name,
-			})
+			issueTypes[index] = option{


Are these changes relevant to the purpose of this PR? Also it seems we may introduce a bug here, since the continue statement above will result in a null pointer on the frontend, since we are "skipping" over that index.

server/settings.go

server/subscribe_test.go

server/webhook_worker.go

… into mm-507

codecov-commenter · 2022-10-19T17:33:30Z

Codecov Report

Patch coverage: 38.84% and project coverage change: +0.44 🎉

Comparison is base (7a5c616) 30.14% compared to head (d769010) 30.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
+ Coverage   30.14%   30.59%   +0.44%     
==========================================
  Files          49       49              
  Lines        7467     7629     +162     
==========================================
+ Hits         2251     2334      +83     
- Misses       5027     5094      +67     
- Partials      189      201      +12

Impacted Files	Coverage Δ
server/client.go	`7.46% <0.00%> (-0.58%)`	⬇️
server/client_cloud.go	`0.00% <ø> (ø)`
server/client_server.go	`0.00% <ø> (ø)`
server/command.go	`15.72% <0.00%> (-0.35%)`	⬇️
server/http.go	`43.67% <ø> (-0.65%)`	⬇️
server/plugin.go	`9.50% <0.00%> (+0.02%)`	⬆️
server/user_cloud.go	`0.00% <0.00%> (ø)`
server/user_server.go	`6.50% <0.00%> (-0.40%)`	⬇️
server/webhook.go	`29.13% <0.00%> (-1.96%)`	⬇️
server/webhook_worker.go	`0.00% <0.00%> (ø)`
... and 4 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* [MI-2088]:Add Support for DM subscriptions for watchers and reporters * [MI-2088]: Review Fixes 1. Improved the name of certain variable 2. Improved spacing * [MI-2088]:Revieww fixes 1.Changes the names of few variables 2.Improved code complexity * [MI-2088]: Review fixes done 1.Changed the name of few variables * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:fixed review fixes * [MI-2088]:Review fixes done 1.Changed the way to store assignee, mention, reporter and watching in struct so that the code can be easily tested * [MI-2088]: Review fixes done 1. Changed the name of various variables 2. Used constants everywhere * [MI-2088]: Review fixes done 1. Added Test cases 2. Used booleans instead of pointer in RolesForDMNotification * [MI-2088]: Review fixes done 1. Modified test cases * [MI-2088]: Review fixes done 1. Self reviewed * [MI-2088]: Review fixes done 1. Changed the formatting 2. Changed the name of few variables 3. Improved code quality * [MI-2088]: Fixes CI errors * [MI-2088]: Review fixes done 1. Improved code quality * [MI-2088]: Review fixes done 1. Improved code quality * [MI-2088]: Review fixes done 1. Improved code quality * [MI-2088]: Fixed CI errors * [MI-2088]: Review fixes done 1. Solved a bug of getting null pointer on frontend. 2. Improved code quality * [MI-2088]: Fixed CI errors * [MI-2088]: Review fixes done 1. Improved code quality * [MI-2088]: Reivew fixes done 1. Improved code quality Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>

mattermost-build · 2023-03-12T01:01:40Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

tomcat78 · 2023-03-27T11:57:50Z

Hey, is there still something blocking this issue? I'd love to have the option to get notifications on tickets, that I watch.

mickmister · 2023-03-28T05:19:27Z

@Kshitij-Katiyar Can you please resolve the merge conflicts here? Thank you 👍

mattermost-build · 2023-04-10T01:01:47Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Kshitij-Katiyar · 2023-06-29T10:10:35Z

@Kshitij-Katiyar Can you please resolve the merge conflicts here? Thank you 👍

@mickmister sure resolving them.

mickmister · 2023-07-06T19:30:20Z

@DHaussermann This PR is ready for QA review

mickmister · 2023-08-25T00:40:24Z

@Kshitij-Katiyar I think we should tell the user why they received a notification. e.g. "because you are watching x" or "because you reported x"

hanzei · 2023-09-01T10:00:22Z

@AayushChaudhary0001 Would you be open to reviewing this PR?

hanzei · 2023-10-16T20:22:35Z

@Kshitij-Katiyar Heads up that there is a conflict to resolve.

mickmister · 2023-12-20T18:37:31Z

@Kshitij-Katiyar I think we should tell the user why they received a notification. e.g. "because you are watching x" or "because you reported x"

I'd like to reiterate this point. I think this would be a big help when using this feature

Kshitij-Katiyar · 2024-07-05T09:45:54Z

This PR was very outdated, which is why we had to create a new one. All the changes from this PR are included in #1097, so we are closing this one.

Kshitij-Katiyar requested a review from mickmister as a code owner September 22, 2022 10:45

mattermod added the Contributor label Sep 22, 2022

[mm-507]:fixed CI error

ba9dfb2

javaguirre reviewed Sep 23, 2022

View reviewed changes

server/settings.go Outdated Show resolved Hide resolved

server/settings.go Outdated Show resolved Hide resolved

server/webhook.go Outdated Show resolved Hide resolved

javaguirre self-requested a review September 27, 2022 08:02

javaguirre suggested changes Sep 29, 2022

View reviewed changes

Kshitij-Katiyar requested review from javaguirre and removed request for mickmister September 30, 2022 10:18

javaguirre suggested changes Sep 30, 2022

View reviewed changes

server/user.go Outdated Show resolved Hide resolved

server/issue.go Outdated Show resolved Hide resolved

server/issue.go Outdated Show resolved Hide resolved

Nityanand13 mentioned this pull request Oct 7, 2022

Review fixes of #872 Brightscout/mattermost-plugin-jira#7

Merged

mickmister suggested changes Oct 17, 2022

View reviewed changes

Nityanand13 mentioned this pull request Oct 18, 2022

[MI-2088]: Review fixes of #872 Brightscout/mattermost-plugin-jira#10

Merged

Merge branch 'master' of github.com:mattermost/mattermost-plugin-jira…

682ba9d

… into mm-507

mattermod added the Lifecycle/1:stale label Nov 2, 2022

mattermost-build added the Lifecycle/1:stale label Mar 12, 2023

mickmister requested a review from DHaussermann March 28, 2023 05:17

mickmister removed Lifecycle/1:stale 2: Dev Review Requires review by a core committer labels Mar 28, 2023

hanzei added the Awaiting Submitter Action Blocked on the author label Mar 30, 2023

mattermost-build added the Lifecycle/1:stale label Apr 10, 2023

mickmister mentioned this pull request Jul 6, 2023

Add support for DM subscriptions based on "watching" an issue in Jira #507

Open

hanzei removed the Awaiting Submitter Action Blocked on the author label Aug 8, 2023

hanzei removed the Lifecycle/1:stale label Sep 1, 2023

hanzei requested review from AayushChaudhary0001 and removed request for DHaussermann October 16, 2023 20:21

hanzei added the Awaiting Submitter Action Blocked on the author label Oct 16, 2023

avas27JTG modified the milestones: v4.1.0, next milestone Dec 21, 2023

This was referenced Jul 3, 2024

[MM-507,699]: Added feature to recieve notification for different Jira actions Brightscout/mattermost-plugin-jira#77

Closed

[MM-507,699]: Added feature to receive notifications for different Jira actions. #1097

Open

Kshitij-Katiyar closed this Jul 5, 2024

mattermost-build removed the Awaiting Submitter Action Blocked on the author label Jul 5, 2024

raghavaggarwal2308 deleted the mm-507 branch July 8, 2024 10:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-507,699] Add Support for DM subscriptions for watchers and reporter #872

[GH-507,699] Add Support for DM subscriptions for watchers and reporter #872

Kshitij-Katiyar commented Sep 22, 2022 •

edited by hanzei

Loading

mattermod commented Sep 22, 2022

javaguirre left a comment

javaguirre commented Sep 27, 2022

javaguirre left a comment

Nityanand13 commented Sep 29, 2022

javaguirre commented Sep 29, 2022

javaguirre left a comment

javaguirre commented Oct 4, 2022

Nityanand13 commented Oct 5, 2022

javaguirre commented Oct 6, 2022

javaguirre commented Oct 6, 2022

Nityanand13 commented Oct 6, 2022

javaguirre commented Oct 11, 2022

javaguirre commented Oct 13, 2022

mickmister left a comment

mickmister Oct 17, 2022

codecov-commenter commented Oct 19, 2022 •

edited

Loading

mattermost-build commented Mar 12, 2023

tomcat78 commented Mar 27, 2023

mickmister commented Mar 28, 2023

mattermost-build commented Apr 10, 2023

Kshitij-Katiyar commented Jun 29, 2023

mickmister commented Jul 6, 2023

mickmister commented Aug 25, 2023

hanzei commented Sep 1, 2023

hanzei commented Oct 16, 2023

mickmister commented Dec 20, 2023

Kshitij-Katiyar commented Jul 5, 2024

[GH-507,699] Add Support for DM subscriptions for watchers and reporter #872

[GH-507,699] Add Support for DM subscriptions for watchers and reporter #872

Conversation

Kshitij-Katiyar commented Sep 22, 2022 • edited by hanzei Loading

mattermod commented Sep 22, 2022

javaguirre left a comment

Choose a reason for hiding this comment

javaguirre commented Sep 27, 2022

javaguirre left a comment

Choose a reason for hiding this comment

Nityanand13 commented Sep 29, 2022

javaguirre commented Sep 29, 2022

javaguirre left a comment

Choose a reason for hiding this comment

javaguirre commented Oct 4, 2022

Nityanand13 commented Oct 5, 2022

javaguirre commented Oct 6, 2022

javaguirre commented Oct 6, 2022

Nityanand13 commented Oct 6, 2022

javaguirre commented Oct 11, 2022

javaguirre commented Oct 13, 2022

mickmister left a comment

Choose a reason for hiding this comment

mickmister Oct 17, 2022

Choose a reason for hiding this comment

codecov-commenter commented Oct 19, 2022 • edited Loading

Codecov Report

mattermost-build commented Mar 12, 2023

tomcat78 commented Mar 27, 2023

mickmister commented Mar 28, 2023

mattermost-build commented Apr 10, 2023

Kshitij-Katiyar commented Jun 29, 2023

mickmister commented Jul 6, 2023

mickmister commented Aug 25, 2023

hanzei commented Sep 1, 2023

hanzei commented Oct 16, 2023

mickmister commented Dec 20, 2023

Kshitij-Katiyar commented Jul 5, 2024

Kshitij-Katiyar commented Sep 22, 2022 •

edited by hanzei

Loading

codecov-commenter commented Oct 19, 2022 •

edited

Loading