Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases for extra check on API of TODO plugin #114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AayushChaudhary0001
Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 commented Sep 22, 2023

Summary

This PR contains the test cases for extra check on API of Todo Plugin

Test coverage for the following API's:-

  • Add_issue
  • Edit_issue
  • Get_issue_list
  • Accept_issue
  • Bump_issue
  • Complete_issue
  • Delete_issue

PR link(for which test cases are added):-mattermost-community/mattermost-plugin-todo#209

* [MI-3533]: Added test cases for extra check on API of ToDO plugin

* [MI-3533]: Review fixes

* Review fix

Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com>

---------

Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com>
@AayushChaudhary0001 AayushChaudhary0001 changed the title [MI-3533]: Added test cases for extra check on API of TODO plugin Added test cases for extra check on API of TODO plugin Sep 25, 2023
@saturninoabril saturninoabril added the 2: QA Review Requires review by a QA tester label Sep 26, 2023
Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AayushChaudhary0001 ,
Wonderful to see you pushing a test cases PR.

I am wondering if you feel we should Add End-2-End scenarios as tests cases that can later be automated as well, rather than API tests as currently described in PR.

Would you be comfortable to add scenarios that a User might face when using the plugin.
Example: Plugin Setup, different Commands, user scope.

@hanzei
Copy link

hanzei commented Oct 16, 2023

@AayushChaudhary0001 Heads up that CI is failing

Copy link
Contributor

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AayushChaudhary0001 The test scripts seem fine to me but as Ben mentioned there is a failing check.

  • 0/5 Edit issue.md has a space in the file name unlike he others which have an underscore but that may not be impactful in any way.
  • Not sure why the check is failing but have you tried running deno task validate?

Copy link
Collaborator

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test files are not in the expected format.
We copy the file at data/TEST_CASE_TEMPLATE.md for reference and make the changes without disturbing any format.

After these changes, the CI should pass. I can confirm as locally it passed after these fixes.

image

folder: ToDo
authors: "@AayushChaudhary0001"
team_ownership:
- Change Team Name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AayushChaudhary0001 , please add team name

name: "Accept Todo"
status: Active
priority: Normal
folder: ToDo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder name will be API.
Also, make the folder name in small case plugins/todo/api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: QA Review Requires review by a QA tester Awaiting Submitter Action Blocked on the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants