Added the test cases for no webhook added on the Github side and overwritten subscriptions on MM. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions on MM. (#28) * [MM-57]: Added the test cases for no webhook and overwritten subscriptions on MM. * [MM-57]: Fixed the comments by Aayush. * [MM-57]: Fixed the comments by Raghav.
|
@DHaussermann @saturninoabril Can you please have a look at this? |
|
Thanks @arush-vashishtha this all looks accurate to me. |
saturninoabril
requested changes
May 8, 2024
| @@ -0,0 +1,42 @@ | |||
| --- | |||
| # (Required) Ensure all values are filled up | |||
| name: "Overwrite the existing subscriptions to a github repo or organization in MM channel" | |||
There was a problem hiding this comment.
Suggested change
| name: "Overwrite the existing subscriptions to a github repo or organization in MM channel" | |
| name: "Overwrite the existing subscriptions to a GitHub repo or organization" |
| @@ -0,0 +1,42 @@ | |||
| --- | |||
| # (Required) Ensure all values are filled up | |||
| name: "An ephemeral post in the chat when the webhook is not found on the github side." | |||
There was a problem hiding this comment.
Suggested change
| name: "An ephemeral post in the chat when the webhook is not found on the github side." | |
| name: "An ephemeral message when no webhook found in GitHub" |
|
|
||
| **Expected** | ||
|
|
||
| The user will get an ephemeral message regarding `no webhook was found for the desired repository or organization` along with the successfull subscription message in the desired channel or DM/GM on MM. |
There was a problem hiding this comment.
Suggested change
| The user will get an ephemeral message regarding `no webhook was found for the desired repository or organization` along with the successfull subscription message in the desired channel or DM/GM on MM. | |
| The user will get an ephemeral message regarding `no webhook was found for the desired repository or organization` along with the successful subscription message in the desired channel or DM/GM on MM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consists the test cases for the following scenarios,