Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-61]: Added the test cases for reopened event on the Github and excluded repositories in an organization. #154

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arush-vashishtha
Copy link
Contributor

@arush-vashishtha arush-vashishtha commented Jan 12, 2024

Summary

This PR consists the test cases for the following scenarios,

  • Excluded repositories while creating subscriptions for a organization on MM.
  • Notification for reopened PR event on Github.

…exclude flag for the repositories in an organization . (#29)

* [MM-61]: Added the test cases for the PR 683 with the --exclude flag.

* [MM-61]: Added the test cases for the PR 718 for reopened PR on gihtub.

* [MM-61]: completed the fixes for the comments by Aayush.

* [MM-61]: completed the fixes for the comments by Aayush.

* [MM-61]: Fixed the comments by Raghav.
@arush-vashishtha
Copy link
Contributor Author

@DHaussermann @saturninoabril Can you please have a look at this?

@lindalumitchell lindalumitchell added the 2: QA Review Requires review by a QA tester label Apr 30, 2024
@DHaussermann DHaussermann self-requested a review May 6, 2024 18:39
@DHaussermann
Copy link
Contributor

Thanks @arush-vashishtha this all looks accurate to me.
The script is fine. I will approve for merge once I confirm if we need any further validation of the Zephyr test data.

Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arush-vashishtha, LGTM except for few comments.

@@ -0,0 +1,48 @@
---
# (Required) Ensure all values are filled up
name: "Excluding subscription in the channel or DM/GM on MM for a repository in a organization "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Excluding subscription in the channel or DM/GM on MM for a repository in a organization "
name: "Excluding subscription in the channel or DM/GM for a repository in an organization"

Comment on lines +45 to +48
**Expected**

No notification should be generated for the triggered event in the desired channel or DM/GM on MM.
After step 2, notification of the triggered event should be shown in the desired channel or DM/GM on MM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please organize following the step/expected format as commented in the other PR.

@@ -0,0 +1,43 @@
---
# (Required) Ensure all values are filled up
name: "Message in the channel or DM/GM on MM regarding the event for reopening a PR on the github"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Message in the channel or DM/GM on MM regarding the event for reopening a PR on the github"
name: "Message in the channel or DM/GM regarding the event for reopening a PR on the GitHub"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants