DC messages #158
Merged
DC messages #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2024
streamer45
added
3: Reviews Complete
* Client metrics * Implement rtc stats monitor * Remove unnecessary parenthesis
streamer45
added a commit
that referenced
this pull request
Oct 9, 2024
* Allow signaling through data channel * Wrap tests * DC messages (#158) * Implement data channel message type * Update client implementation * Update godeltaprof * Fix dc init race * [MM-60561] RTC client metrics (#159) * Client metrics * Implement rtc stats monitor * Remove unnecessary parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Building on top of the previous PR (#156), we introduce a simple (msgpack based) format for messages exchanged through the data channel. The idea is to support a variety of different messages in the future, including some QoE metrics coming from clients.