[MM-60561] RTC client metrics #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2024
cpoile
approved these changes
Oct 9, 2024
client/rtc_monitor.go
Outdated
Comment on lines
108
to
109
| avgJitter = (totalJitter / statsCount) | ||
| avgLossRate = totalLossRate / statsCount |
client/rtc_monitor.go
Outdated
Comment on lines
139
to
140
| avgJitter = (totalJitter / statsCount) | ||
| avgLossRate = totalLost / totalReceived |
There was a problem hiding this comment.
same nit
(not important of course)
There was a problem hiding this comment.
I would have expected a linter to say something. Will review 👍
Comment on lines
+194
to
+202
| statsInterceptorFactory, err := stats.NewInterceptor() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create stats interceptor: %w", err) | ||
| } | ||
| var statsGetter stats.Getter | ||
| statsInterceptorFactory.OnNewPeerConnection(func(_ string, g stats.Getter) { | ||
| statsGetter = g | ||
| }) | ||
| i.Add(statsInterceptorFactory) |
There was a problem hiding this comment.
I'm not sure I fully understand this block here.... Oh, intercepter is provided by pion, and a pc always has a stats.Getter... I'm not sure what we do with this exact statsGetter..?
streamer45
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Oct 9, 2024
* Implement data channel message type * Update client implementation * Update godeltaprof * Fix dc init race * [MM-60561] RTC client metrics (#159) * Client metrics * Implement rtc stats monitor * Remove unnecessary parenthesis
streamer45
added a commit
that referenced
this pull request
Oct 9, 2024
* Allow signaling through data channel * Wrap tests * DC messages (#158) * Implement data channel message type * Update client implementation * Update godeltaprof * Fix dc init race * [MM-60561] RTC client metrics (#159) * Client metrics * Implement rtc stats monitor * Remove unnecessary parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adds support for receiving and tracking basic client metrics (round trip time, jitter and loss rate). These can then be easily surfaced through our existing Prometheus/Grafana stack (see screenshot).
I also added a basic Golang client implementation, however it's not very accurate given some limitations in the pion implementation (jitter is especially problematic). We are keeping these off by default so that we don't get wild reports from transcriber or other clients we may have in production.
Screenshot
Related PRs
mattermost/calls-common#41
Ticket Link
https://mattermost.atlassian.net/browse/MM-60561