Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release #34

Open
katopz opened this issue Feb 16, 2023 · 0 comments
Open

Make a release #34

katopz opened this issue Feb 16, 2023 · 0 comments

Comments

@katopz
Copy link

katopz commented Feb 16, 2023

Usually I did this on github build.yml.

name: Mdbook build

on:
  push:
    branches: ['main']

jobs:
  build:
    name: build
    runs-on: ubuntu-latest
    env:
      MDBOOK_VERSION: '0.4.22'
      MDBOOK_LINKCHECK_VERSION: '0.7.4'
      MDBOOK_MERMAID_VERSION: '0.12.2'
    steps:
      - uses: actions/checkout@v3
        with:
          submodules: true
      - name: Install mdbook
        run: |
          mkdir ~/tools
          curl -L https://github.com/rust-lang/mdBook/releases/download/v$MDBOOK_VERSION/mdbook-v$MDBOOK_VERSION-x86_64-unknown-linux-gnu.tar.gz | tar xz -C ~/tools
          curl -L https://github.com/badboy/mdbook-mermaid/releases/download/v$MDBOOK_MERMAID_VERSION/mdbook-mermaid-v$MDBOOK_MERMAID_VERSION-x86_64-unknown-linux-gnu.tar.gz | tar xz -C ~/tools
          curl -L https://github.com/Michael-F-Bryan/mdbook-linkcheck/releases/download/v$MDBOOK_LINKCHECK_VERSION/mdbook-linkcheck.v$MDBOOK_LINKCHECK_VERSION.x86_64-unknown-linux-gnu.zip -O
          unzip mdbook-linkcheck.v$MDBOOK_LINKCHECK_VERSION.x86_64-unknown-linux-gnu.zip -d ~/tools
          chmod +x ~/tools/mdbook-linkcheck
          curl -s https://api.github.com/repos/zjp-CN/mdbook-theme/releases/latest \
                 | grep browser_download_url \
                 | grep mdbook-theme_linux \
                 | cut -d '"' -f 4 \
                 | wget -qi -
          tar -xzf mdbook-theme_linux.tar.gz -C ~/tools
          echo ~/tools >> $GITHUB_PATH

      - name: Install mdbook-svgbob
        run: cargo install mdbook-svgbob --version 0.2.1

      - name: Build
        run: mdbook build
      # share between different jobs
      - uses: actions/upload-artifact@v3
        with:
          name: book
          path: book/

and it took 4 minutes for this Install mdbook-svgbob step.

 Updating crates.io index
 Downloading crates ...
  Downloaded mdbook-svgbob v0.2.1
  Installing mdbook-svgbob v0.2.1
   ...
   Compiling mdbook-svgbob v0.2.1
    Finished release [optimized] target(s) in 4m 09s
  Installing /home/runner/.cargo/bin/mdbook-svgbob
   Installed package `mdbook-svgbob v0.2.1` (executable `mdbook-svgbob`)

So it would be nice if we have released version like mdbook-mermaid so it can reduce build time to <1m there.
Nothing urgent btw, just nice to have.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant