Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): [engine] Improperly indexing into params map #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmmulroy
Copy link

@dmmulroy dmmulroy commented Feb 28, 2024

In associateMatchedParameters we are indexing into the params map/object while iterating over the matchedParams by using params.parameter. This should actually be params[parameter]. All tests are still passing, so there seems to be no obvious regressions.

Copy link

changeset-bot bot commented Feb 28, 2024

⚠️ No Changeset found

Latest commit: 751b42d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mattpocock
Copy link
Owner

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants