Adding block cache so that it can support full page caching of concrete5 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In concrete5, they have cache system.
But all blocks doesn't have the setting to support cache.
Adding cache option
I don't find any reason why Form, Content and Video should allow concrete5 to cache its content.
Since the dynamic contents are loaded via JS, so cocnrete5 side could be cached.
Therefore, I add the option to cache.
Tracker cache setting to be true for registered user
Changed the cache setting to registered user.
I can see the cases where concrete5 accept public registration such as community site.
"register usess" also include those public users.
So I suggest to change to cache the registered user as well.
Thanks.