From 6f9927c3991a5acb185a3877c7bec0c8e3798a56 Mon Sep 17 00:00:00 2001
From: Tulir Asokan <tulir@maunium.net>
Date: Sun, 15 Sep 2024 01:11:53 +0300
Subject: [PATCH] crypto: make OTK count for other user log less noisy

---
 crypto/machine.go | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/crypto/machine.go b/crypto/machine.go
index 85da2b3b..c130f775 100644
--- a/crypto/machine.go
+++ b/crypto/machine.go
@@ -65,8 +65,9 @@ type OlmMachine struct {
 	megolmEncryptLock sync.Mutex
 	megolmDecryptLock sync.Mutex
 
-	otkUploadLock sync.Mutex
-	lastOTKUpload time.Time
+	otkUploadLock       sync.Mutex
+	lastOTKUpload       time.Time
+	receivedOTKsForSelf bool
 
 	CrossSigningKeys    *CrossSigningKeysCache
 	crossSigningPubkeys *CrossSigningPublicKeysCache
@@ -258,16 +259,15 @@ func (mach *OlmMachine) otkCountIsForCrossSigningKey(otkCount *mautrix.OTKCount)
 
 func (mach *OlmMachine) HandleOTKCounts(ctx context.Context, otkCount *mautrix.OTKCount) {
 	if (len(otkCount.UserID) > 0 && otkCount.UserID != mach.Client.UserID) || (len(otkCount.DeviceID) > 0 && otkCount.DeviceID != mach.Client.DeviceID) {
-		if mach.otkCountIsForCrossSigningKey(otkCount) {
-			return
+		if otkCount.UserID != mach.Client.UserID || (!mach.receivedOTKsForSelf && !mach.otkCountIsForCrossSigningKey(otkCount)) {
+			mach.Log.Warn().
+				Str("target_user_id", otkCount.UserID.String()).
+				Str("target_device_id", otkCount.DeviceID.String()).
+				Msg("Dropping OTK counts targeted to someone else")
 		}
-		// TODO This log probably needs to be silence-able if someone wants to use encrypted appservices with multiple e2ee sessions
-		mach.Log.Warn().
-			Str("target_user_id", otkCount.UserID.String()).
-			Str("target_device_id", otkCount.DeviceID.String()).
-			Msg("Dropping OTK counts targeted to someone else")
 		return
 	}
+	mach.receivedOTKsForSelf = true
 
 	minCount := mach.account.Internal.MaxNumberOfOneTimeKeys() / 2
 	if otkCount.SignedCurve25519 < int(minCount) {