Don't search MAVLINK_STX with last char of bad packet #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User A add a new mavlink message, but user B din't add the message. This common situation will lead to extremely occasional packet loss in user B. When user B receive the undefined message, mavlink_parse_char() will enter MAVLINK_FRAMING_BAD_CRC status, and check the undefined message last char. If the last char happens to be MAVLINK_STX value, then the subsequent valid packets will parse wrong and lead to lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deleted code always causes extremely occasional packet loss. Details are as follows.
User A add a new mavlink message, but user B din't add the message. This common situation will lead to extremely occasional packet loss in user B. When user B receive the undefined message, mavlink_parse_char() will enter MAVLINK_FRAMING_BAD_CRC status, and check the undefined message last char. If the last char happens to be MAVLINK_STX value, then the subsequent valid packets will parse wrong and lost.