fix ament_cpplint

libmavconn/include/mavconn/interface.hpp

@@ -23,8 +23,6 @@
 #ifndef MAVCONN__INTERFACE_HPP_
 #define MAVCONN__INTERFACE_HPP_
 
-#include <mavconn/mavlink_dialect.hpp>
-
 #include <atomic>
 #include <cassert>
 #include <chrono>
@@ -40,6 +38,8 @@
 #include <unordered_map>
 #include <vector>
 
+#include <mavconn/mavlink_dialect.hpp>
+
 namespace mavconn
 {
 using steady_clock = std::chrono::steady_clock;

libmavconn/include/mavconn/msgbuffer.hpp

@@ -19,9 +19,10 @@
 #ifndef MAVCONN__MSGBUFFER_HPP_
 #define MAVCONN__MSGBUFFER_HPP_
 
-#include <mavconn/mavlink_dialect.hpp>
 #include <cassert>
 
+#include <mavconn/mavlink_dialect.hpp>
+
 namespace mavconn
 {
 

libmavconn/include/mavconn/serial.hpp

@@ -19,14 +19,14 @@
 #ifndef MAVCONN__SERIAL_HPP_
 #define MAVCONN__SERIAL_HPP_
 
-#include <mavconn/interface.hpp>
-#include <mavconn/msgbuffer.hpp>
-
-#include <asio.hpp>
 #include <atomic>
 #include <deque>
 #include <string>
 
+#include <asio.hpp>
+#include <mavconn/interface.hpp>
+#include <mavconn/msgbuffer.hpp>
+
 namespace mavconn
 {
 

libmavconn/include/mavconn/tcp.hpp

@@ -19,17 +19,17 @@
 #ifndef MAVCONN__TCP_HPP_
 #define MAVCONN__TCP_HPP_
 
-#include <mavconn/interface.hpp>
-#include <mavconn/msgbuffer.hpp>
-
-#include <asio.hpp>
 #include <atomic>
 #include <cstring>
 #include <deque>
 #include <list>
 #include <memory>
 #include <string>
 
+#include <asio.hpp>
+#include <mavconn/interface.hpp>
+#include <mavconn/msgbuffer.hpp>
+
 namespace mavconn
 {
 

libmavconn/include/mavconn/udp.hpp

@@ -19,15 +19,15 @@
 #ifndef MAVCONN__UDP_HPP_
 #define MAVCONN__UDP_HPP_
 
-#include <mavconn/interface.hpp>
-#include <mavconn/msgbuffer.hpp>
-
-#include <asio.hpp>
 #include <atomic>
 #include <deque>
 #include <memory>
 #include <string>
 
+#include <asio.hpp>
+#include <mavconn/interface.hpp>
+#include <mavconn/msgbuffer.hpp>
+
 namespace mavconn
 {
 

libmavconn/src/interface.cpp

@@ -15,19 +15,19 @@
  * @{
  */
 
-#include <mavconn/console_bridge_compat.hpp>
-#include <mavconn/interface.hpp>
-#include <mavconn/msgbuffer.hpp>
-#include <mavconn/serial.hpp>
-#include <mavconn/tcp.hpp>
-#include <mavconn/udp.hpp>
-
 #include <cassert>
 #include <memory>
 #include <set>
 #include <string>
 #include <unordered_map>
 
+#include "mavconn/console_bridge_compat.hpp"
+#include "mavconn/interface.hpp"
+#include "mavconn/msgbuffer.hpp"
+#include "mavconn/serial.hpp"
+#include "mavconn/tcp.hpp"
+#include "mavconn/udp.hpp"
+
 namespace mavconn
 {
 #define PFX "mavconn: "

libmavconn/src/serial.cpp

@@ -19,13 +19,13 @@
 #include <linux/serial.h>
 #endif
 
-#include <mavconn/console_bridge_compat.hpp>
-#include <mavconn/serial.hpp>
-#include <mavconn/thread_utils.hpp>
-
 #include <cassert>
 #include <string>
 
+#include "mavconn/console_bridge_compat.hpp"
+#include "mavconn/serial.hpp"
+#include "mavconn/thread_utils.hpp"
+
 namespace mavconn
 {
 

libmavconn/src/tcp.cpp

@@ -15,15 +15,15 @@
  * @{
  */
 
-#include <mavconn/console_bridge_compat.hpp>
-#include <mavconn/tcp.hpp>
-#include <mavconn/thread_utils.hpp>
-
 #include <cassert>
 #include <memory>
 #include <string>
 #include <unordered_map>
 
+#include "mavconn/console_bridge_compat.hpp"
+#include "mavconn/tcp.hpp"
+#include "mavconn/thread_utils.hpp"
+
 // Ensure the correct io_service() is called based on asio version
 #if ASIO_VERSION >= 101400
 #define GET_IO_SERVICE(s) ((asio::io_context &)(s).get_executor().context())

libmavconn/src/udp.cpp

@@ -15,13 +15,13 @@
  * @{
  */
 
-#include <mavconn/console_bridge_compat.hpp>
-#include <mavconn/thread_utils.hpp>
-#include <mavconn/udp.hpp>
-
 #include <cassert>
 #include <string>
 
+#include "mavconn/console_bridge_compat.hpp"
+#include "mavconn/thread_utils.hpp"
+#include "mavconn/udp.hpp"
+
 namespace mavconn
 {
 

libmavconn/test/test_mavconn.cpp

@@ -11,11 +11,6 @@
  * Test mavconn library
  */
 
-#include <mavconn/interface.hpp>
-#include <mavconn/serial.hpp>
-#include <mavconn/tcp.hpp>
-#include <mavconn/udp.hpp>
-
 // Gmock broken on Ubuntu (thrusty),
 //  its gmock 1.6 require gtest 1.7, while repository only provides 1.6
 //  this error exist one year without any updates.
@@ -30,6 +25,11 @@
 #include <limits>
 #include <memory>
 
+#include "mavconn/interface.hpp"
+#include "mavconn/serial.hpp"
+#include "mavconn/tcp.hpp"
+#include "mavconn/udp.hpp"
+
 using namespace mavconn; // NOLINT
 using mavlink_message_t = mavlink::mavlink_message_t;
 using msgid_t = mavlink::msgid_t;

mavros/src/lib/ftf_frame_conversions.cpp

@@ -16,8 +16,8 @@
  * @{
  */
 
-#include <mavros/frame_tf.hpp>
 #include <stdexcept>
+#include <mavros/frame_tf.hpp>
 
 namespace mavros
 {

mavros/src/plugins/command.cpp

@@ -489,7 +489,7 @@ class CommandPlugin : public plugin::Plugin
     send_command_long_and_wait(
       false,
       enum_value(MAV_CMD::NAV_LAND_LOCAL), 1,
-      0, //landing target number (what does it means?)
+      0,  // landing target number (what does it means?)
       req->offset,
       req->rate,
       req->yaw,

mavros/src/plugins/sys_status.cpp

@@ -1108,7 +1108,7 @@ class SystemStatusPlugin : public plugin::Plugin
       has_battery_status0 = true;
     }
 
-    if (!disable_diag && bs.id >= 0 && bs.id < MAX_NR_BATTERY_STATUS) {
+    if (!disable_diag && bs.id < MAX_NR_BATTERY_STATUS) {
       batt_diag[bs.id].set(total_voltage, batt_msg.current, batt_msg.percentage);
       batt_diag[bs.id].setcell_v(batt_msg.cell_voltage);
     }

mavros/test/test_quaternion_utils.cpp

@@ -12,11 +12,11 @@
  */
 
 #include <gtest/gtest.h>
+#include <tf2/LinearMath/Quaternion.h>
+#include <tf2/LinearMath/Matrix3x3.h>
 
 #include <rclcpp/rclcpp.hpp>
 #include <mavros/frame_tf.hpp>
-#include <tf2/LinearMath/Quaternion.hpp>
-#include <tf2/LinearMath/Matrix3x3.hpp>
 
 using namespace mavros;     // NOLINT