Bug fixes in translating from Mavlink to ROS-Mavlink #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug mavlink#569 from mavros. Fixed another bug in the building of the ros mavlink message- the seq field was not added to the ros mavlink message.
Kept mavlink#569 FIXME tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The None in the signing field (bug #569) made the code throw exceptions while decoding. There is still no signing support, but the empty array is working better than the None value. Fixed another bug in the building of the ROS Mavlink message- the seq field was not added to the ROS Mavlink message, causing a CRC error while decoding the message.