Add dependency on yaml-cpp in mavros_extras #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the compilation errors described in #1960 by adding the
yaml-cppdependency tomavros_extrasfor ROS 2 Jazzy and Rolling. These changes also aid in closing #1958 (once the build is updated to support those releases).Tridge has already made the relevant changes to pymavlink to support Python 3.12, which is included in the latest version pointed to by mavlink. If this looks good to be released for Jazzy and Rolling, I can submit an additional PR with a section in the README pointing to the Jazzy build status.