Signing #516
test.yml
on: pull_request
Annotations
25 warnings
casting to the same type is unnecessary (`u32` -> `u32`):
mavlink-bindgen/src/parser.rs#L333
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> mavlink-bindgen/src/parser.rs:333:35
|
333 | cnt = cnt.max(tmp_value as u32);
| ^^^^^^^^^^^^^^^^ help: try: `tmp_value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
the borrowed expression implements the required traits:
mavlink-bindgen/src/lib.rs#L42
warning: the borrowed expression implements the required traits
--> mavlink-bindgen/src/lib.rs:42:33
|
42 | for entry_maybe in read_dir(&definitions_dir).map_err(|source| {
| ^^^^^^^^^^^^^^^^ help: change this to: `definitions_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
mavlink-bindgen/src/lib.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> mavlink-bindgen/src/lib.rs:70:26
|
70 | parser::generate(&definitions_dir, &definition_file, &mut outf)?;
| ^^^^^^^^^^^^^^^^ help: change this to: `definitions_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
unused variable: `signing_data`:
mavlink-core/src/lib.rs#L802
warning: unused variable: `signing_data`
--> mavlink-core/src/lib.rs:802:5
|
802 | signing_data: Option<&SigningData>,
| ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_signing_data`
|
= note: `#[warn(unused_variables)]` on by default
|
this looks like an `else if` but the `else` is missing:
target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs#L1
warning: this looks like an `else if` but the `else` is missing
--> /home/runner/work/rust-mavlink/rust-mavlink/target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs:1:626579
|
1 | ...es, but got {})" , Self :: ENCODED_LEN , __tmp . remaining () ,) } if matches ! (version , MavlinkVersion :: V2) { let len = __tmp . l...
| ^
|
= note: to remove this lint, add the missing `else` or add a new line before the second `if`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
= note: `#[warn(clippy::suspicious_else_formatting)]` on by default
|
this looks like an `else if` but the `else` is missing:
target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs#L1
warning: this looks like an `else if` but the `else` is missing
--> /home/runner/work/rust-mavlink/rust-mavlink/target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs:1:909823
|
1 | ...es, but got {})" , Self :: ENCODED_LEN , __tmp . remaining () ,) } if matches ! (version , MavlinkVersion :: V2) { let len = __tmp . l...
| ^
|
= note: to remove this lint, add the missing `else` or add a new line before the second `if`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
|
unused import: `crate::test_shared`:
mavlink/tests/tcp_loopback_tests.rs#L10
warning: unused import: `crate::test_shared`
--> mavlink/tests/tcp_loopback_tests.rs:10:9
|
10 | use crate::test_shared;
| ^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
variable does not need to be mutable:
mavlink/tests/tcp_loopback_tests.rs#L24
warning: variable does not need to be mutable
--> mavlink/tests/tcp_loopback_tests.rs:24:17
|
24 | let mut server =
| ----^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
variable does not need to be mutable:
mavlink/tests/tcp_loopback_tests.rs#L57
warning: variable does not need to be mutable
--> mavlink/tests/tcp_loopback_tests.rs:57:17
|
57 | let mut client =
| ----^^^^^^
| |
| help: remove this `mut`
|
msrv
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
msrv
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (ubuntu-latest, thumbv7m-none-eabi, --no-default-features --features embedded)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (ubuntu-latest, thumbv7m-none-eabi, --no-default-features --features embedded)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (ubuntu-latest, armv7-unknown-linux-musleabihf, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (ubuntu-latest, armv7-unknown-linux-musleabihf, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (ubuntu-latest, arm-unknown-linux-musleabihf, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (ubuntu-latest, arm-unknown-linux-musleabihf, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (macos-latest, x86_64-apple-darwin, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (macos-latest, x86_64-apple-darwin, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega,emit-description,emit-e...
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega,emit-description,emit-e...
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build (windows-latest, x86_64-pc-windows-msvc, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (windows-latest, x86_64-pc-windows-msvc, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|