Skip to content

mavlink-core: src: Fix embedded v2 read header #518

mavlink-core: src: Fix embedded v2 read header

mavlink-core: src: Fix embedded v2 read header #518

Triggered via pull request August 22, 2024 17:18
Status Success
Total duration 8m 50s
Artifacts

test.yml

on: pull_request
Matrix: internal-tests
test-embedded-size
40s
test-embedded-size
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
casting to the same type is unnecessary (`u32` -> `u32`): mavlink-bindgen/src/parser.rs#L333
warning: casting to the same type is unnecessary (`u32` -> `u32`) --> mavlink-bindgen/src/parser.rs:333:35 | 333 | cnt = cnt.max(tmp_value as u32); | ^^^^^^^^^^^^^^^^ help: try: `tmp_value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
the borrowed expression implements the required traits: mavlink-bindgen/src/lib.rs#L42
warning: the borrowed expression implements the required traits --> mavlink-bindgen/src/lib.rs:42:33 | 42 | for entry_maybe in read_dir(&definitions_dir).map_err(|source| { | ^^^^^^^^^^^^^^^^ help: change this to: `definitions_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: mavlink-bindgen/src/lib.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler --> mavlink-bindgen/src/lib.rs:70:26 | 70 | parser::generate(&definitions_dir, &definition_file, &mut outf)?; | ^^^^^^^^^^^^^^^^ help: change this to: `definitions_dir` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
this looks like an `else if` but the `else` is missing: target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs#L1
warning: this looks like an `else if` but the `else` is missing --> /home/runner/work/rust-mavlink/rust-mavlink/target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs:1:267094 | 1 | ...es, but got {})" , Self :: ENCODED_LEN , __tmp . remaining () ,) } if matches ! (version , MavlinkVersion :: V2) { let len = __tmp . l... | ^ | = note: to remove this lint, add the missing `else` or add a new line before the second `if` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting = note: `#[warn(clippy::suspicious_else_formatting)]` on by default
this looks like an `else if` but the `else` is missing: target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs#L1
warning: this looks like an `else if` but the `else` is missing --> /home/runner/work/rust-mavlink/rust-mavlink/target/debug/build/mavlink-abf65506d51c3f54/out/ardupilotmega.rs:1:869417 | 1 | ...es, but got {})" , Self :: ENCODED_LEN , __tmp . remaining () ,) } if matches ! (version , MavlinkVersion :: V2) { let len = __tmp . l... | ^ | = note: to remove this lint, add the missing `else` or add a new line before the second `if` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
msrv
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
msrv
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (ubuntu-latest, thumbv7m-none-eabi, --no-default-features --features embedded)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest, thumbv7m-none-eabi, --no-default-features --features embedded)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (macos-latest, x86_64-apple-darwin, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (macos-latest, x86_64-apple-darwin, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (ubuntu-latest, arm-unknown-linux-musleabihf, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest, arm-unknown-linux-musleabihf, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega,emit-description,emit-e...
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest, x86_64-unknown-linux-musl, --features ardupilotmega,emit-description,emit-e...
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (ubuntu-latest, armv7-unknown-linux-musleabihf, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (ubuntu-latest, armv7-unknown-linux-musleabihf, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
build (windows-latest, x86_64-pc-windows-msvc, --features ardupilotmega)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build (windows-latest, x86_64-pc-windows-msvc, --features ardupilotmega)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/