Update MSRV check to account for features #531
danieleadestest.yml
on: pull_request
Matrix: internal-tests
Matrix: msrv
docs
32s
Matrix: build
test-embedded-size
0s
Annotations
5 errors and 5 warnings
|
msrv (--features tokio-1)
Process completed with exit code 1.
|
|
msrv
The job was canceled because "_--features_tokio-1" failed.
|
|
msrv
The operation was canceled.
|
|
msrv (--features serde)
The job was canceled because "_--features_tokio-1" failed.
|
|
msrv (--features serde)
The operation was canceled.
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
mavlink-bindgen/src/parser.rs#L333
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> mavlink-bindgen/src/parser.rs:333:35
|
333 | cnt = cnt.max(tmp_value as u32);
| ^^^^^^^^^^^^^^^^ help: try: `tmp_value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
the borrowed expression implements the required traits:
mavlink-bindgen/src/lib.rs#L42
warning: the borrowed expression implements the required traits
--> mavlink-bindgen/src/lib.rs:42:33
|
42 | for entry_maybe in read_dir(&definitions_dir).map_err(|source| {
| ^^^^^^^^^^^^^^^^ help: change this to: `definitions_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
mavlink-bindgen/src/lib.rs#L70
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> mavlink-bindgen/src/lib.rs:70:26
|
70 | parser::generate(&definitions_dir, &definition_file, &mut outf)?;
| ^^^^^^^^^^^^^^^^ help: change this to: `definitions_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
this looks like an `else if` but the `else` is missing:
target/debug/build/mavlink-4cef7ab582e64247/out/ardupilotmega.rs#L1
warning: this looks like an `else if` but the `else` is missing
--> /home/runner/work/rust-mavlink/rust-mavlink/target/debug/build/mavlink-4cef7ab582e64247/out/ardupilotmega.rs:1:266703
|
1 | ...es, but got {})" , Self :: ENCODED_LEN , __tmp . remaining () ,) } if matches ! (version , MavlinkVersion :: V2) { let len = __tmp . l...
| ^
|
= note: to remove this lint, add the missing `else` or add a new line before the second `if`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
= note: `#[warn(clippy::suspicious_else_formatting)]` on by default
|
|
this looks like an `else if` but the `else` is missing:
target/debug/build/mavlink-4cef7ab582e64247/out/ardupilotmega.rs#L1
warning: this looks like an `else if` but the `else` is missing
--> /home/runner/work/rust-mavlink/rust-mavlink/target/debug/build/mavlink-4cef7ab582e64247/out/ardupilotmega.rs:1:843758
|
1 | ...es, but got {})" , Self :: ENCODED_LEN , __tmp . remaining () ,) } if matches ! (version , MavlinkVersion :: V2) { let len = __tmp . l...
| ^
|
= note: to remove this lint, add the missing `else` or add a new line before the second `if`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting
|