Skip to content

Commit

Permalink
feat: add signing, tokio-1 to clippy test
Browse files Browse the repository at this point in the history
feat: add signing to msrv check
fix: test_tcp_connections import order
revert: add default features on accident
  • Loading branch information
pv42 committed Aug 22, 2024
1 parent 3e7c4a7 commit 865962d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
components: clippy
- uses: actions-rs-plus/clippy-check@v2
with:
args: --all --all-targets --features format-generated-code
args: --all --all-targets --features format-generated-code --features signing --features tokio-1

internal-tests:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
with:
use-cross: true
command: check
args: --all --all-targets
args: --all --all-targets --features signing

build:
needs: [formatting, linting, internal-tests, mavlink-dump, msrv]
Expand Down
3 changes: 1 addition & 2 deletions mavlink-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,4 @@ sha2 = { version = "0.10", optional = true }
"serde" = ["dep:serde", "dep:serde_arrays"]
"tokio-1" = ["dep:tokio"]
"signing" = ["dep:sha2"]
# DO NOT COMMIT
default = ["std", "tcp", "udp", "direct-serial", "serde", "tokio-1", "signing"]
default = ["std", "tcp", "udp", "direct-serial", "serde"]
4 changes: 2 additions & 2 deletions mavlink/tests/tcp_loopback_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ mod test_shared;
mod test_tcp_connections {
use std::thread;

#[cfg(feature = "signing")]
use mavlink::SigningConfig;
#[cfg(feature = "signing")]
use crate::test_shared;
#[cfg(feature = "signing")]
use mavlink::SigningConfig;

/// Test whether we can send a message via TCP and receive it OK. This also test signing as a property of a MavConnection if the signing feature is enabled.
#[test]
Expand Down

0 comments on commit 865962d

Please sign in to comment.