Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align MSRV check with 'rust-version' #200

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

danieleades
Copy link
Contributor

the MSRV check should match the 'rust-version' specified in Cargo.toml

@danieleades
Copy link
Contributor Author

as you can see from the failed test, the rust-version in Cargo.toml is not correct. I'll have to bump the version to get this to build

@danieleades danieleades marked this pull request as draft October 22, 2023 15:53
@danieleades danieleades marked this pull request as ready for review October 22, 2023 16:12
@danieleades
Copy link
Contributor Author

i've left the commits in there for ease of review, but you probably want to squash merge this

@patrickelectric
Copy link
Member

Thanks @danieleades, can you squash the commits ? We don't have squash merge enable for better descriptive commit messages.

@danieleades
Copy link
Contributor Author

Thanks @danieleades, can you squash the commits ? We don't have squash merge enable for better descriptive commit messages.

What is the impact on commit messages of using github's squash merge? It gives you the option of setting the commit message when you merge, no?

@patrickelectric patrickelectric merged commit 74243e3 into mavlink:master Oct 22, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants