0.10: Fix serialization and deserialization problems #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
changed the title
patrickelectric
force-pushed
the
improve-tests-0.10
branch
from
53ba3d0
to
518dc4c
Compare
joaoantoniocardoso
approved these changes
Nov 21, 2023
| } | ||
|
|
||
| #[test] | ||
| pub fn test_deser_ser_message() { |
There was a problem hiding this comment.
This test would be awesome with proptest
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com> Co-authored-by: : Ihsen Bouallegue <48621967+IhsenBouallegue@users.noreply.github.com>
As described on the documentation: 0 - magic 1 - len 2 - seq 3 - sysid 4 - compid Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
improve-tests-0.10
branch
from
518dc4c
to
c4d2c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #204 #206 #207