Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Replace default isize enum representation. #214

Merged

Conversation

antonio-sc66
Copy link
Contributor

@antonio-sc66 antonio-sc66 commented Jan 3, 2024

By default Rust uses isize to represent enum values. isize implementation depends on the target_pointer_width attribute, which differs from arch to arch.

  • Mavlink implementation for v2 requires message id with the range 0..16777215 --> u32
  • Mavlink implementation requires u32 enum entry values

Closes #211

By default Rust uses isize to represent enum values.
isize implementation depends on the `target_pointer_width` attribute.

- Mavlink implementation for v2 requires message id with the range 0..16777215 --> u32
- Mavlink implementation requires u32 enum entry values
@patrickelectric patrickelectric merged commit 76a2813 into mavlink:master Jan 3, 2024
19 of 20 checks passed
@antonio-sc66 antonio-sc66 deleted the feature-bugfix-enum-datatypes branch January 3, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All enum entries and message ids use isize, some should use usize
2 participants