Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update 'embedded_hal' #267

Closed
wants to merge 1 commit into from
Closed

chore(deps): update 'embedded_hal' #267

wants to merge 1 commit into from

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Aug 25, 2024 •
edited
Loading

does CI actually cover this feature?

@danieleades danieleades marked this pull request as ready for review August 25, 2024 18:46
@patrickelectric
Copy link
Member

does CI actually cover this feature?

Yes https://github.com/mavlink/rust-mavlink/actions/runs/10548211116/job/29221931254

@danieleades
Copy link
Contributor Author

ah i think i see what's going on here. the embedded_hal_02 dependency is essentially a feature which pins to an older version. Therefore this PR should not be merged.

when embedded-io provides feature parity the embedded_hal_02 dependency/feature should be removed, not updated.

@danieleades danieleades deleted the deps.embedded_hal branch August 26, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieleades @patrickelectric