feedback

- fix permission in job page
- don't show the button for built-in node
- improve jelly doc

core/src/main/resources/hudson/model/Job/index.jelly

@@ -41,7 +41,7 @@ THE SOFTWARE.
           </h1>
         </div>
         <div class="jenkins-app-bar__controls">
-          <t:editDescriptionButton permission="${it.UPDATE}"/>
+          <t:editDescriptionButton permission="${it.CONFIGURE}"/>
         </div>
       </div>
 

core/src/main/resources/lib/hudson/editDescriptionButton.jelly

@@ -1,6 +1,8 @@
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:l="/lib/layout">
     <st:documentation>
+        Renders a button to add/edit the description of an item. Typically used when the button should appear in the
+        app-bar instead of appearing below the description. To be used in combination with `editableDescription`.
         <st:attribute name="permission" use="required">
             If the current user doesn't have this permission, the description
             is not editable.
@@ -15,7 +17,7 @@
     <j:set var="actualDescription" value="${description}" defaultValue="${it.description}"/>
     <l:hasPermission permission="${permission}">
         <st:adjunct includes="lib.hudson.editable-description"/>
-        <a class="jenkins-button" id="description-link" href="editDescription" data-description="${actualDescription}" data-url="${submissionUrl}">
+        <a class="jenkins-button jenkins-hidden" id="description-link" href="editDescription" data-description="${actualDescription}" data-url="${submissionUrl}">
             <l:icon src="symbol-edit" />
             <j:choose>
                 <j:when test="${empty(actualDescription)}">

core/src/main/resources/lib/hudson/editable-description.js

@@ -2,12 +2,16 @@
 (function () {
   document.addEventListener("DOMContentLoaded", function () {
     let descriptionLink = document.querySelector("#description-link");
-    descriptionLink.addEventListener("click", function (e) {
-      e.preventDefault();
-      descriptionLink.classList.add("jenkins-hidden");
-      let url = descriptionLink.getAttribute("data-url");
-      let description = descriptionLink.getAttribute("data-description");
-      return replaceDescription(description, url);
-    });
+    let description = document.getElementById("description");
+    if (description != null) {
+      descriptionLink.classList.remove("jenkins-hidden");
+      descriptionLink.addEventListener("click", function (e) {
+        e.preventDefault();
+        descriptionLink.classList.add("jenkins-hidden");
+        let url = descriptionLink.getAttribute("data-url");
+        let description = descriptionLink.getAttribute("data-description");
+        return replaceDescription(description, url);
+      });
+    }
   });
 })();

core/src/main/resources/lib/hudson/editableDescription.jelly

@@ -39,7 +39,8 @@ THE SOFTWARE.
       Optional submission URL. If not specified, will use 'submitDescription'.
     </st:attribute>
     <st:attribute name="hideButton">
-      Hide the add/edit description button. To be used when the button is provided via the app bar.
+      Hide the add/edit description button. Set to true when the button is provided via the app bar.
+      See 'editDescriptionButton'
     </st:attribute>
   </st:documentation>