From c1335f821bad7b8d31e9eff328719c2b9b4d584b Mon Sep 17 00:00:00 2001 From: Markus Winter Date: Thu, 22 Aug 2024 20:56:47 +0200 Subject: [PATCH] don't use backdrop for dialogs The backdrop can make dialogs look really bad when there are large areas with dark color right behind the dialog (see screenshot). --- war/src/main/scss/abstracts/_theme.scss | 1 - war/src/main/scss/components/_dialogs.scss | 2 -- 2 files changed, 3 deletions(-) diff --git a/war/src/main/scss/abstracts/_theme.scss b/war/src/main/scss/abstracts/_theme.scss index cc21f1e8ab90..98a51fe77c8c 100644 --- a/war/src/main/scss/abstracts/_theme.scss +++ b/war/src/main/scss/abstracts/_theme.scss @@ -217,7 +217,6 @@ $semantics: ( --dialog-backdrop-background: hsla(240, 10%, 20%, 0.8); } - --dialog-backdrop-filter: brightness(3) blur(50px); --dialog-box-shadow: 0 10px 40px rgba(0, 0, 20, 0.15), 0 2px 15px rgba(0, 0, 20, 0.05), inset 0 0 2px 2px rgba(255, 255, 255, 0.025); diff --git a/war/src/main/scss/components/_dialogs.scss b/war/src/main/scss/components/_dialogs.scss index 3de2d0c883a0..7040c70af0e2 100644 --- a/war/src/main/scss/components/_dialogs.scss +++ b/war/src/main/scss/components/_dialogs.scss @@ -3,9 +3,7 @@ $jenkins-dialog-padding: 1.3rem; .jenkins-dialog { border-radius: 0.6rem; border: none; - background: transparent; box-shadow: var(--dialog-box-shadow); - backdrop-filter: var(--dialog-backdrop-filter); animation: jenkins-dialog-animate-in 0.25s cubic-bezier(0, 0.68, 0.5, 1.5); overflow: hidden; padding: $jenkins-dialog-padding 0 0 0;