Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretAgent deadlocked after Sonoma 14.4.1 upgrade #543

Open
mischaelschill opened this issue Apr 18, 2024 · 18 comments
Open

SecretAgent deadlocked after Sonoma 14.4.1 upgrade #543

mischaelschill opened this issue Apr 18, 2024 · 18 comments

Comments

@mischaelschill
Copy link

After upgrading to Sonoma 14.4.1 (skipping 14.4.0), the SecretAgent is locking up regularly. The symptom is ssh blocking indefinitely while waiting for the SecretAgent. If the SecretAgent is killed (e.g. by pkill SecretAgent), ssh works fine for a little while.
Unfortunately, I do not know where to look for the log file of the SecretAgent.

@maxgoedjen
Copy link
Owner

I'm not aware of any known issues on 14.4.1 (that's what I'm using) – can you take a sample of SecretAgent next time this happens? Open Activity Manager and select "Sample Process" here:
image

@mischaelschill
Copy link
Author

Sample of SecretAgent.txt

@3apa3a-b-ta3e
Copy link

Sample of SecretAgent.txt

Here is mine.

@lenovouser
Copy link

I also have this on macOS 14.5

@bicrypt
Copy link

bicrypt commented May 26, 2024

Same here, since yesterday it started to consume a lot of CPU for the initial SSH connection while also taking several seconds to complete.

I am running macOS 14.5 since around 10 days & build 2.4.1 since months, but it started to get slow yesterday.

@3apa3a-b-ta3e
Copy link

Just to add — it happens more frequently when there is a VSCode opened and doing background repo refresh.
Which hasn't been an issue with previous macOS/Secretive versions.

@zviratko
Copy link

I am seeing this issue as well. When logging in, there's a STORM of messages seen in "log stream", but apparently unrelated to Secretive itself.
I think it's actually caused by iTerm, it doesn't happen in Terminal (but there are many differences between those two when it comes to sessions and stuff, so it isnt' fair to outright blame iTerm). But since that't the only thing I regularly update (running nightly build), I think it points to that.

@zviratko
Copy link

Ok, I'm more ready to blame iTerm now :) Apparently 3.5.0 came out May 17th. As I'm running nightly I didn't really notice anything. Downgrading to 3.4.23 fixes the issue, upgrading to 3.5.0 brings it back. I'm not sure how long I had this issue without noticing, but it can't be that long, I also skipped a few nightlies so it could be 2 weeks. Something just before the release broke it.

@zviratko
Copy link

@mischaelschill
Copy link
Author

The issue persists, and I'm not using iTerm. It is not a delay, the process is stuck until killed. I now have a job which kills the process every 10 Minutes which alleviates the problem.

@zviratko
Copy link

I think that's a separate issue. I see high CPU usage and delay when the agent is signing.

@slimm609
Copy link

iterm 3.5.1 resolves the issue for me

@Manouchehri
Copy link

Likewise! It's like night and day.

@rfscouto
Copy link

Still facing the issue even not having iTerm installed. I also have Visual Studio, Intellij and Warp.

@mischaelschill
Copy link
Author

Any news? I'm still affected on 14.5

@rfscouto
Copy link

same here

@zeha
Copy link

zeha commented Sep 23, 2024

Also have this on 14.7 (23H124), no iTerm.

@CGamesPlay
Copy link

CGamesPlay commented Oct 9, 2024

I have a consistent repro for this.

  1. ssh-add -l, responses return immediately because SecretAgent is responsive.
  2. In a background terminal, run nc -U $SSH_AUTH_SOCK.
  3. ssh-add -l, hangs, SecretAgent is not responsive.
  4. Kill the netcat, the hung ssh-add will return results immediately.

I can't be sure that this is the same hang that VSCode produces, but hopefully it can help to debug. This repro works for me on macOS 12.7.1 (21G920), with Secretive Version 2.4.1 (1.7648958148).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests