fix(deps): update rust crate raw-window-handle to 0.6 #11271
clippy
2 errors, 13 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 2 |
Warning | 13 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 91 in crates/components/connections/protocols/pro-dj-link/src/discovery.rs
github-actions / clippy
this `if let` can be collapsed into the outer `if let`
warning: this `if let` can be collapsed into the outer `if let`
--> crates/components/connections/protocols/pro-dj-link/src/discovery.rs:85:29
|
85 | / ... if let ProDJLinkDevice::CDJ(cdj) = device {
86 | | ... cdj.speed = packet.speed;
87 | | ... cdj.beat = packet.beat;
88 | | ... if let Err(err) = sender.send(ProDJLinkDevice::CDJ(cdj.clone())) {
89 | | ... tracing::error!("Failed to send CDJ device: {err:?}");
90 | | ... }
91 | | ... }
| |_______________________^
|
help: the outer pattern can be modified to include the inner pattern
--> crates/components/connections/protocols/pro-dj-link/src/discovery.rs:84:37
|
84 | if let Some(device) = devices.get_mut(&packet.device_id) {
| ^^^^^^ replace this binding
85 | if let ProDJLinkDevice::CDJ(cdj) = device {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
= note: `#[warn(clippy::collapsible_match)]` on by default
Check warning on line 29 in crates/components/connections/protocols/dmx/src/buffer.rs
github-actions / clippy
using `clone` on type `[u8; 512]` which implements the `Copy` trait
warning: using `clone` on type `[u8; 512]` which implements the `Copy` trait
--> crates/components/connections/protocols/dmx/src/buffer.rs:29:56
|
29 | self.buffers.iter().map(|entry| (*entry.key(), entry.value().clone()))
| ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*entry.value()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
Check warning on line 80 in crates/components/connections/protocols/dmx/src/inputs/artnet.rs
github-actions / clippy
field `thread` is never read
warning: field `thread` is never read
--> crates/components/connections/protocols/dmx/src/inputs/artnet.rs:80:5
|
79 | struct ThreadHandle {
| ------------ field in this struct
80 | thread: JoinHandle<()>,
| ^^^^^^
|
= note: `ThreadHandle` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
Check failure on line 24 in crates/runtime/wgpu/src/window/raw_window_ref.rs
github-actions / clippy
mismatched types
error[E0308]: mismatched types
--> crates/runtime/wgpu/src/window/raw_window_ref.rs:24:9
|
23 | fn raw_display_handle(&self) -> RawDisplayHandle {
| ---------------- expected `raw_window_handle::RawDisplayHandle` because of return type
24 | self.window.raw_display_handle()
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `RawDisplayHandle`, found `Result<RawDisplayHandle, ...>`
|
= note: expected enum `raw_window_handle::RawDisplayHandle`
found enum `std::result::Result<raw_window_handle::RawDisplayHandle, raw_window_handle::HandleError>`
help: consider using `Result::expect` to unwrap the `std::result::Result<raw_window_handle::RawDisplayHandle, raw_window_handle::HandleError>` value, panicking if the value is a `Result::Err`
|
24 | self.window.raw_display_handle().expect("REASON")
| +++++++++++++++++
Check warning on line 24 in crates/runtime/wgpu/src/window/raw_window_ref.rs
github-actions / clippy
use of deprecated method `raw_window_handle::HasRawDisplayHandle::raw_display_handle`: Use `HasDisplayHandle` instead
warning: use of deprecated method `raw_window_handle::HasRawDisplayHandle::raw_display_handle`: Use `HasDisplayHandle` instead
--> crates/runtime/wgpu/src/window/raw_window_ref.rs:24:21
|
24 | self.window.raw_display_handle()
| ^^^^^^^^^^^^^^^^^^
Check failure on line 22 in crates/runtime/wgpu/src/window/raw_window_ref.rs
github-actions / clippy
conflicting implementations of trait `raw_window_handle::HasRawDisplayHandle` for type `window::raw_window_ref::RawWindowRef`
error[E0119]: conflicting implementations of trait `raw_window_handle::HasRawDisplayHandle` for type `window::raw_window_ref::RawWindowRef`
--> crates/runtime/wgpu/src/window/raw_window_ref.rs:22:1
|
22 | unsafe impl HasRawDisplayHandle for RawWindowRef {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: conflicting implementation in crate `raw_window_handle`:
- impl<T> raw_window_handle::HasRawDisplayHandle for T
where T: raw_window_handle::HasDisplayHandle, T: ?Sized;
Check warning on line 22 in crates/runtime/wgpu/src/window/raw_window_ref.rs
github-actions / clippy
use of deprecated trait `raw_window_handle::HasRawDisplayHandle`: Use `HasDisplayHandle` instead
warning: use of deprecated trait `raw_window_handle::HasRawDisplayHandle`: Use `HasDisplayHandle` instead
--> crates/runtime/wgpu/src/window/raw_window_ref.rs:22:13
|
22 | unsafe impl HasRawDisplayHandle for RawWindowRef {
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 5 in crates/runtime/wgpu/src/window/raw_window_ref.rs
github-actions / clippy
use of deprecated trait `raw_window_handle::HasRawDisplayHandle`: Use `HasDisplayHandle` instead
warning: use of deprecated trait `raw_window_handle::HasRawDisplayHandle`: Use `HasDisplayHandle` instead
--> crates/runtime/wgpu/src/window/raw_window_ref.rs:5:25
|
5 | use raw_window_handle::{HasRawDisplayHandle, RawDisplayHandle};
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
Check warning on line 8 in crates/util/src/conversion.rs
github-actions / clippy
clamp-like pattern without using clamp function
warning: clamp-like pattern without using clamp function
--> crates/util/src/conversion.rs:8:9
|
8 | (self * u8::MAX as f64).min(255.).max(0.).floor() as u8
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(self * u8::MAX as f64).clamp(0., 255.)`
|
= note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
= note: clamp returns NaN if the input is NaN
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
= note: `#[warn(clippy::manual_clamp)]` on by default
Check warning on line 11 in crates/runtime/commander/src/extractors/sub_command.rs
github-actions / clippy
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/runtime/commander/src/extractors/sub_command.rs:11:39
|
11 | pub fn apply(self, command: T) -> anyhow::Result<(T::Result, (T, T::State))> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 97 in crates/runtime/module/src/lib.rs
github-actions / clippy
bound is defined in more than one place
warning: bound is defined in more than one place
--> crates/runtime/module/src/lib.rs:97:24
|
97 | fn block_in_thread<A: 'static, F: Future + 'static>(&self, future_action: A)
| ^
98 | where
99 | A: FnOnce() -> F + Send;
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
= note: `#[warn(clippy::multiple_bound_locations)]` on by default
Check warning on line 143 in crates/runtime/commander/src/extractors/tuples.rs
github-actions / clippy
unneeded unit expression
warning: unneeded unit expression
--> crates/runtime/commander/src/extractors/tuples.rs:143:9
|
143 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
Check warning on line 34 in crates/runtime/debug-ui/src/noop.rs
github-actions / clippy
unneeded unit expression
warning: unneeded unit expression
--> crates/runtime/debug-ui/src/noop.rs:34:9
|
34 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
Check warning on line 13 in crates/runtime/debug-ui/src/noop.rs
github-actions / clippy
unneeded unit expression
warning: unneeded unit expression
--> crates/runtime/debug-ui/src/noop.rs:13:9
|
13 | ()
| ^^ help: remove the final `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
= note: `#[warn(clippy::unused_unit)]` on by default
Check warning on line 134 in crates/util/bus/src/lib.rs
github-actions / clippy
field `0` is never read
warning: field `0` is never read
--> crates/util/bus/src/lib.rs:134:37
|
134 | struct SubscriberStream<T: 'static>(Arc<flume::Sender<T>>, RecvStream<'static, T>);
| ---------------- ^^^^^^^^^^^^^^^^^^^^^
| |
| field in this struct
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
134 | struct SubscriberStream<T: 'static>((), RecvStream<'static, T>);
| ~~