Skip to content

chore(deps): update docker/build-push-action action to v6 #6286

chore(deps): update docker/build-push-action action to v6

chore(deps): update docker/build-push-action action to v6 #6286

GitHub Actions / clippy succeeded Jul 17, 2024 in 2s

clippy

170 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 170
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 77 in crates/mizer/src/logger.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> crates/mizer/src/logger.rs:77:25
   |
77 | pub struct LoggingGuard(Option<WorkerGuard>);
   |            ------------ ^^^^^^^^^^^^^^^^^^^
   |            |
   |            field in this struct
   |
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
77 | pub struct LoggingGuard(());
   |                         ~~

Check warning on line 2 in crates/mizer/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `anyhow::Context`

warning: unused import: `anyhow::Context`
 --> crates/mizer/src/main.rs:2:5
  |
2 | use anyhow::Context;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

Check warning on line 49 in crates/mizer/src/module_context.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> crates/mizer/src/module_context.rs:49:24
   |
49 |     fn block_in_thread<A: 'static, F: Future + 'static>(&self, future_action: A)
   |                        ^
50 |     where
51 |         A: FnOnce() -> F + Send,
   |         ^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 40 in crates/ui/src/plugin/channels/method/surfaces.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `mizer_api::proto::surfaces::SurfaceTransform`

warning: useless conversion to the same type: `mizer_api::proto::surfaces::SurfaceTransform`
  --> crates/ui/src/plugin/channels/method/surfaces.rs:40:25
   |
40 |                         req.transform.unwrap().into(),
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `req.transform.unwrap()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 279 in crates/ui/src/plugin/channels/method/programmer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> crates/ui/src/plugin/channels/method/programmer.rs:279:26
    |
279 |         let programmer = Arc::new(programmer);
    |                          ^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<Programmer>` is not `Send` and `Sync` as `Programmer` is neither `Send` nor `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `Programmer` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 217 in crates/ui/src/plugin/channels/method/nodes.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> crates/ui/src/plugin/channels/method/nodes.rs:217:28
    |
217 |         let metadata_ref = Arc::new(NodesRef::new(metadata_ref));
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<NodesRef>` is not `Send` and `Sync` as `NodesRef` is neither `Send` nor `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `NodesRef` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 207 in crates/ui/src/plugin/channels/method/nodes.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> crates/ui/src/plugin/channels/method/nodes.rs:207:27
    |
207 |             let preview = Arc::new(preview);
    |                           ^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<NodeHistory>` is not `Send` and `Sync` as `NodeHistory` is neither `Send` nor `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `NodeHistory` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync

Check warning on line 246 in crates/ui/src/plugin/channels/method/layouts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
   --> crates/ui/src/plugin/channels/method/layouts.rs:246:23
    |
246 |         let layouts = Arc::new(layouts);
    |                       ^^^^^^^^^^^^^^^^^
    |
    = note: `Arc<LayoutRef>` is not `Send` and `Sync` as `LayoutRef` is neither `Send` nor `Sync`
    = help: if the `Arc` will not used be across threads replace it with an `Rc`
    = help: otherwise make `LayoutRef` `Send` and `Sync` or consider a wrapper type such as `Mutex`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
    = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 76 in crates/ui/src/plugin/event_sink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

bound is defined in more than one place

warning: bound is defined in more than one place
  --> crates/ui/src/plugin/event_sink.rs:76:24
   |
76 |     fn run_in_run_loop<Cb: 'static>(&self, cb: Cb)
   |                        ^^
77 |     where
78 |         Cb: FnOnce(&InnerSubscriber) + Send,
   |         ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `#[warn(clippy::multiple_bound_locations)]` on by default

Check warning on line 14 in crates/api/src/mappings/settings.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
  --> crates/api/src/mappings/settings.rs:14:15
   |
14 |             ..Default::default()
   |               ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 25 in crates/api/src/mappings/sequencer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::option::Option<proto::sequencer::CueTime>`

warning: useless conversion to the same type: `std::option::Option<proto::sequencer::CueTime>`
  --> crates/api/src/mappings/sequencer.rs:25:23
   |
25 |                 time: cue.trigger_time.map(|time| time.into()).into(),
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cue.trigger_time.map(|time| time.into())`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check warning on line 26 in crates/api/src/mappings/sequencer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
  --> crates/api/src/mappings/sequencer.rs:26:19
   |
26 |                 ..Default::default()
   |                   ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 263 in crates/api/src/mappings/programmer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> crates/api/src/mappings/programmer.rs:263:23
    |
263 |                     ..Default::default()
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 43 in crates/api/src/mappings/plans.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
  --> crates/api/src/mappings/plans.rs:43:23
   |
43 |                     ..Default::default()
   |                       ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 29 in crates/api/src/mappings/plans.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
  --> crates/api/src/mappings/plans.rs:29:23
   |
29 |                     ..Default::default()
   |                       ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 17 in crates/api/src/mappings/plans.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
  --> crates/api/src/mappings/plans.rs:17:23
   |
17 |                     ..Default::default()
   |                       ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 46 in crates/api/src/mappings/plans.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
  --> crates/api/src/mappings/plans.rs:46:15
   |
46 |             ..Default::default()
   |               ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 311 in crates/api/src/mappings/nodes.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::iter::FilterMap<std::iter::Cloned<std::slice::Iter<'_, i32>>, fn(i32) -> std::option::Option<proto::media::MediaType>>`

warning: useless conversion to the same type: `std::iter::FilterMap<std::iter::Cloned<std::slice::Iter<'_, i32>>, fn(i32) -> std::option::Option<proto::media::MediaType>>`
   --> crates/api/src/mappings/nodes.rs:309:32
    |
309 |                   content_types: value
    |  ________________________________^
310 | |                     .allowed_types()
311 | |                     .into_iter()
    | |________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into_iter()`
    |
309 ~                 content_types: value
310 +                     .allowed_types()
    |

Check warning on line 28 in crates/api/src/mappings/media.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::option::Option<proto::media::media_metadata::Dimensions>`

warning: useless conversion to the same type: `std::option::Option<proto::media::media_metadata::Dimensions>`
  --> crates/api/src/mappings/media.rs:24:29
   |
24 |                   dimensions: media
   |  _____________________________^
25 | |                     .metadata
26 | |                     .dimensions
27 | |                     .map(|(width, height)| media_metadata::Dimensions { width, height })
28 | |                     .into(),
   | |___________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
help: consider removing `.into()`
   |
24 ~                 dimensions: media
25 +                     .metadata
26 +                     .dimensions
27 ~                     .map(|(width, height)| media_metadata::Dimensions { width, height }),
   |

Check warning on line 93 in crates/api/src/mappings/layouts.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::option::Option<proto::layouts::Color>`

warning: useless conversion to the same type: `std::option::Option<proto::layouts::Color>`
  --> crates/api/src/mappings/layouts.rs:93:20
   |
93 |             color: decorations.color.map(Color::from).into(),
   |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `decorations.color.map(Color::from)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 302 in crates/api/src/mappings/fixtures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> crates/api/src/mappings/fixtures.rs:302:23
    |
302 |                     ..Default::default()
    |                       ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 304 in crates/api/src/mappings/fixtures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> crates/api/src/mappings/fixtures.rs:304:19
    |
304 |                 ..Default::default()
    |                   ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 296 in crates/api/src/mappings/fixtures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> crates/api/src/mappings/fixtures.rs:296:19
    |
296 |                 ..Default::default()
    |                   ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 286 in crates/api/src/mappings/fixtures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> crates/api/src/mappings/fixtures.rs:286:15
    |
286 |             ..Default::default()
    |               ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update

Check warning on line 250 in crates/api/src/mappings/fixtures.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

struct update has no effect, all the fields in the struct have already been specified

warning: struct update has no effect, all the fields in the struct have already been specified
   --> crates/api/src/mappings/fixtures.rs:250:15
    |
250 |             ..Default::default()
    |               ^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update