Parametrize callback views #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different configurations may come with different requirements, for example our own concrete model is intended for the admin, so the callback view should only redirect to the admin failure URL when that config is applied. The config class can now provide a view function/callable to use, and custom views can easily be subclassed from our base view. TODO: documentation
sergei-maertens
force-pushed
the
feature/99-parametrized-callback-view
branch
from
a363b91 to
6cc0e61
Compare
stevenbal
requested changes
May 24, 2024
sergei-maertens
force-pushed
the
feature/99-parametrized-callback-view
branch
from
6cc0e61 to
b844327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99
This is the last bit for the view/backend aspect, the refresh middleware will need to be tackled in another phase as that one seems trickier.
I noticed in Open Forms that I was struggling to implement the error handling during the callback view, there are essentially 3 possible flows (admin login, org-oid and digid/eh oidc) where the latter two are similar but not the same. The code organization for this is pretty nasty since those auth plugins should be decoupled from each other.
This view rework solves that - it allows us to use a single (!) callback endpoint while customizing the behaviour at the view level. The config class is used to route/invoke the desired view callable.