Block following redirects in logout #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the logout operation response returns an HTTP 302, it's possible this redirect causes crashes when they're being followed/retrieved via requests. In it's simplest case, a 404 could already cause problems.
Block following redirect responses from programmatically calling the logout operation, for two reasons: * they may be incomplete endpoints, e.g. the Redirect URI but without state parameter or token or anything, which would fail anyway. These can cause HTTP 500 errors in downstream projects (as seen in Open Forms). * they can lead to SSRF issues if we don't validate the redirect target URL - a malicious/bad OpenID Provider could be a part of a larger chain of exploits
sergei-maertens
requested review from
stevenbal and
vaszig
and removed request for
vaszig
stevenbal
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes open-formulieren/open-forms#4379