-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#474] Fix version number #475
base: master
Are you sure you want to change the base?
Conversation
6775aa0
to
3c5824f
Compare
#476 was merged, so if you rebase on master, the check OAF version action should now pass |
@@ -4,6 +4,7 @@ | |||
|
|||
from .base import * # noqa isort:skip | |||
|
|||
os.environ.setdefault("RELEASE", API_VERSION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API_VERSION
is the version of the API endpoint itself and we want to show the version of the application in the admin. This should be the RELEASE
setting defined in open-api-framework
https://github.com/maykinmedia/open-api-framework/blob/main/open_api_framework/conf/base.py#L640. I'm not sure why it isn't picked up here though, maybe it's not being set in the Docker image?
5c8c3b6
to
407b61f
Compare
Fixes #474
Fixes maykinmedia/open-api-framework#82
The version number is already correctly set up in open-api-framework, but in objects-api PROD was not configured, so the change is to set the value of the environment variables ‘RELEASE’ with the value from api.py