Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#467] Setup objecttypes through django-setup-configuration #492

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Dec 12, 2024

Fixes #467

Changes

Allows the configuration of Service's with django-setup-configuration to setup a connection with objecttype(s)

@SonnyBA
Copy link
Contributor Author

SonnyBA commented Dec 12, 2024

I haven't prefixed e495899 (with the ticket number) as I will cherry pick those for #491

@SonnyBA SonnyBA marked this pull request as ready for review December 12, 2024 16:42
@SonnyBA SonnyBA self-assigned this Dec 12, 2024
api_root: http://objecttypes.local/api/v1/
api_connection_check_path: objecttypes
api_type: orc
auth_type: api_key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also set the headers to make it a bit more of a real example:

header_key: Authorization
header_value: Token b9f100590925b529664ed9d370f5f8da124b2c20

Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

docs/installation/config_cli.rst Outdated Show resolved Hide resolved
docs/installation/config_cli.rst Outdated Show resolved Hide resolved
docs/installation/config_cli.rst Outdated Show resolved Hide resolved
src/objects/core/models.py Outdated Show resolved Hide resolved
@@ -0,0 +1,10 @@
objecttypes_config_enable: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need separate files for these tests? Most of them seem the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the idempotent test file, the other files are quite different from each other

@SonnyBA SonnyBA force-pushed the feature/467-objecttypes-setup-config-branched branch from 725525b to 90c27c0 Compare December 13, 2024 14:09
@SonnyBA SonnyBA merged commit a2678c7 into master Dec 13, 2024
14 checks passed
@SonnyBA SonnyBA deleted the feature/467-objecttypes-setup-config-branched branch December 13, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Objecttype-configuration via django-setup-configuration
3 participants