New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: convert eslint to flat config #582

Closed

sergei-maertens opened this issue Jan 3, 2025 · 1 comment · Fixed by #583

Assignees

Member

sergei-maertens commented Jan 3, 2025

Following open-formulieren/open-forms-sdk#724 - let's see if we can establish a common baseline config to share across maykin projects.

sergei-maertens self-assigned this

Contributor

svenvandescheur commented Jan 6, 2025

svenvandescheur mentioned this issue

Migrate to ESLint flat config #583

Merged

3 tasks

sergei-maertens added a commit that referenced this issue


          🔨 [#582] Replace ESLint config with flat config

72c9287

CRA ships with a default ESLint config, which is overridden in the
project to disable some bits. ESLint is moving towards flat config,
and CRA (unmaintained) is not compatible with it, so we set up our own
flows.

The envvar disables the CRA integration in react-scripts, as it does
not pick up the new config file. The pre-commit checks and CI pipeline
ensure that code is properly linted before being committed.

We also use the shared config from Maykin for consistency across
projects.

sergei-maertens added a commit that referenced this issue


          🙈 [#582] Ensure that storybook-static build directory is ignored

d1b1987

sergei-maertens added a commit that referenced this issue


          🚨 [#582] Address linter errors

7025fa4

Addressed the linter errors to minimize the impact on the project.

Some lines are ignored because they are valid and consistent in the
project, but ignoring the rule as a whole would allow other mistakes to
fall through/go undetected.

sergei-maertens added a commit that referenced this issue


          🔨 [#582] Replace ESLint config with flat config

47e0f6c

CRA ships with a default ESLint config, which is overridden in the
project to disable some bits. ESLint is moving towards flat config,
and CRA (unmaintained) is not compatible with it, so we set up our own
flows.

The envvar disables the CRA integration in react-scripts, as it does
not pick up the new config file. The pre-commit checks and CI pipeline
ensure that code is properly linted before being committed.

We also use the shared config from Maykin for consistency across
projects.

sergei-maertens added a commit that referenced this issue


          🙈 [#582] Ensure that storybook-static build directory is ignored

94693b6

sergei-maertens added a commit that referenced this issue


          🚨 [#582] Address linter errors

7fd21a1

Addressed the linter errors to minimize the impact on the project.

Some lines are ignored because they are valid and consistent in the
project, but ignoring the rule as a whole would allow other mistakes to
fall through/go undetected.

sergei-maertens added a commit that referenced this issue


          🔨 [#582] Replace ESLint config with flat config

9c534bd

CRA ships with a default ESLint config, which is overridden in the
project to disable some bits. ESLint is moving towards flat config,
and CRA (unmaintained) is not compatible with it, so we set up our own
flows.

The envvar disables the CRA integration in react-scripts, as it does
not pick up the new config file. The pre-commit checks and CI pipeline
ensure that code is properly linted before being committed.

We also use the shared config from Maykin for consistency across
projects.

sergei-maertens added a commit that referenced this issue


          🙈 [#582] Ensure that storybook-static build directory is ignored

592219e

sergei-maertens added a commit that referenced this issue


          🚨 [#582] Address linter errors

7e80c8a

Addressed the linter errors to minimize the impact on the project.

Some lines are ignored because they are valid and consistent in the
project, but ignoring the rule as a whole would allow other mistakes to
fall through/go undetected.

sergei-maertens added a commit that referenced this issue


          🔨 [#582] Replace ESLint config with flat config

06afe5f

CRA ships with a default ESLint config, which is overridden in the
project to disable some bits. ESLint is moving towards flat config,
and CRA (unmaintained) is not compatible with it, so we set up our own
flows.

The envvar disables the CRA integration in react-scripts, as it does
not pick up the new config file. The pre-commit checks and CI pipeline
ensure that code is properly linted before being committed.

We also use the shared config from Maykin for consistency across
projects.

sergei-maertens added a commit that referenced this issue


          🙈 [#582] Ensure that storybook-static build directory is ignored

3c21f10

sergei-maertens added a commit that referenced this issue


          🚨 [#582] Address linter errors

729e216

Addressed the linter errors to minimize the impact on the project.

Some lines are ignored because they are valid and consistent in the
project, but ignoring the rule as a whole would allow other mistakes to
fall through/go undetected.

svenvandescheur pushed a commit that referenced this issue


          🔨 [#582] Replace ESLint config with flat config

fc7c697

CRA ships with a default ESLint config, which is overridden in the
project to disable some bits. ESLint is moving towards flat config,
and CRA (unmaintained) is not compatible with it, so we set up our own
flows.

The envvar disables the CRA integration in react-scripts, as it does
not pick up the new config file. The pre-commit checks and CI pipeline
ensure that code is properly linted before being committed.

We also use the shared config from Maykin for consistency across
projects.

svenvandescheur closed this as completed in #583

svenvandescheur pushed a commit that referenced this issue


          🙈 [#582] Ensure that storybook-static build directory is ignored

df22cf7

svenvandescheur pushed a commit that referenced this issue


          🚨 [#582] Address linter errors

7ba0203

Addressed the linter errors to minimize the impact on the project.

Some lines are ignored because they are valid and consistent in the
project, but ignoring the rule as a whole would allow other mistakes to
fall through/go undetected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment