From 728a45754b6d3377d98b19e40d00b8ec5acf5903 Mon Sep 17 00:00:00 2001 From: Sidney Richards Date: Thu, 17 Oct 2024 09:58:23 +0200 Subject: [PATCH] Disable playwright browser cache in CI As per the Playwright docs, caching browsers is not recommended, both because downloading the binary is not much slower, but also because system dependencies are required, and these cannot be cached. Even worse, the system dependencies can become stale as the CI images get upgraded. This seems to have happened recently, with persistent "It looks like you are using Playwright Sync API inside the asyncio loop." errors sporadically appearing (in this case, for webkit only) and this being fixed, without further code changes, by disabling the browser cache. --- .github/workflows/ci.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f0867b97f4..e35a74295a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -166,14 +166,6 @@ jobs: setup-node: 'yes' npm-ci-flags: '--legacy-peer-deps' - # See https://playwright.dev/python/docs/ci#caching-browsers - - name: Cache Playwright browser - id: cache-browser - uses: actions/cache@v3 - with: - path: /home/runner/.cache/ms-playwright - key: ${{ runner.os }}-${{ matrix.browser }}-playwright-${{ hashFiles('requirements/ci.txt') }} - - name: Install playwright deps run: playwright install --with-deps ${{ matrix.browser }}