Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2093] Upgrade django admin index #1014

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Feb 8, 2024

Taiga: #2093

Related: recent switch to maykin-2fa (#1003)

@pi-sigma pi-sigma changed the title Upgrade/django admin index [#2093] Upgrade django admin index Feb 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f62132f) 94.83% compared to head (31c5d0a) 94.83%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1014   +/-   ##
========================================
  Coverage    94.83%   94.83%           
========================================
  Files          880      882    +2     
  Lines        30704    30713    +9     
========================================
+ Hits         29119    29128    +9     
  Misses        1585     1585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from d03b7fb to 412272c Compare February 8, 2024 15:50
@pi-sigma pi-sigma marked this pull request as ready for review February 9, 2024 12:04
@pi-sigma pi-sigma requested a review from jiromaykin February 9, 2024 12:04
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like this more! No more bad responsiveness and a clearer difference in hover colors.

It does still show the same jQuery error in console sometimes where it cannot find 'Django/django is not defined' but I guess that's still part of the package, so prob. no need to do anything there.

Just one small thing that is annoying on mobile: is how #changelist-filter completely covers the other content (because the surrounding #changelist is display:grid on mobile) - you can see this on http://localhost:8000/admin/openzaak/zaaktypeconfig/ and for small screens just set it to display block.

I can't remember where but I saw some pages were checking to see if they could fin the #scroll-anchor/"style display" and shows a console error; which may be solved by adding a condition such as if (mybutton) {...) around the function in src/open_inwoner/js/components/anchor-menu/scroll_to_top.js

Screenshot 2024-02-12 at 11 59 30

@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch 2 times, most recently from 7ceea1f to e3a5d76 Compare February 15, 2024 14:02
@pi-sigma pi-sigma requested a review from jiromaykin February 15, 2024 15:01
@pi-sigma
Copy link
Contributor Author

@jiromaykin e2e tests are still failing but we need to move forward. Thanks for your suggestions, they're implemented!

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny change needed, IF I am not the only one seeing this :-)

.dropdown-menu__item:visited {
color: $color_lightest;
/* Added to attach to body/breadcrumbs */
border-bottom: $djai-border-width solid $color_secondary;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the culprit here - but I see an odd border on the bottom here that makes the header/menu jump out strangley.
Do you also see this? I've added the inspector: if you toggle the border off, it looks normal.

adminmenu1

Clearer view on left-side only (but it's also happening on the right-hand side):

adminmenu2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I removed the border.

@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from e3a5d76 to bb9ec6e Compare February 16, 2024 10:31
@pi-sigma pi-sigma requested a review from jiromaykin February 16, 2024 11:07
@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from bb9ec6e to ed47743 Compare February 19, 2024 08:37
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from ed47743 to 383cf5b Compare February 19, 2024 09:25
@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from 383cf5b to 264b12f Compare February 19, 2024 11:22
@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from 264b12f to e29731f Compare February 20, 2024 08:09
@pi-sigma pi-sigma force-pushed the upgrade/django-admin-index branch from e29731f to 31c5d0a Compare February 20, 2024 08:10
@pi-sigma pi-sigma merged commit 670730a into develop Feb 20, 2024
17 checks passed
@pi-sigma pi-sigma deleted the upgrade/django-admin-index branch February 20, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants