-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2093] Upgrade django admin index #1014
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1014 +/- ##
========================================
Coverage 94.83% 94.83%
========================================
Files 880 882 +2
Lines 30704 30713 +9
========================================
+ Hits 29119 29128 +9
Misses 1585 1585 ☔ View full report in Codecov by Sentry. |
d03b7fb
to
412272c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like this more! No more bad responsiveness and a clearer difference in hover colors.
It does still show the same jQuery error in console sometimes where it cannot find 'Django/django is not defined' but I guess that's still part of the package, so prob. no need to do anything there.
Just one small thing that is annoying on mobile: is how #changelist-filter
completely covers the other content (because the surrounding #changelist
is display:grid on mobile) - you can see this on http://localhost:8000/admin/openzaak/zaaktypeconfig/ and for small screens just set it to display block.
I can't remember where but I saw some pages were checking to see if they could fin the #scroll-anchor/"style display" and shows a console error; which may be solved by adding a condition such as if (mybutton) {...)
around the function in src/open_inwoner/js/components/anchor-menu/scroll_to_top.js
7ceea1f
to
e3a5d76
Compare
@jiromaykin e2e tests are still failing but we need to move forward. Thanks for your suggestions, they're implemented! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny change needed, IF I am not the only one seeing this :-)
.dropdown-menu__item:visited { | ||
color: $color_lightest; | ||
/* Added to attach to body/breadcrumbs */ | ||
border-bottom: $djai-border-width solid $color_secondary; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the culprit here - but I see an odd border on the bottom here that makes the header/menu jump out strangley.
Do you also see this? I've added the inspector: if you toggle the border off, it looks normal.
Clearer view on left-side only (but it's also happening on the right-hand side):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I removed the border.
e3a5d76
to
bb9ec6e
Compare
bb9ec6e
to
ed47743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
ed47743
to
383cf5b
Compare
383cf5b
to
264b12f
Compare
264b12f
to
e29731f
Compare
e29731f
to
31c5d0a
Compare
Taiga: #2093
Related: recent switch to maykin-2fa (#1003)