[#2598] Refactor notifications #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1289 +/- ##
========================================
Coverage 95.12% 95.12%
========================================
Files 983 990 +7
Lines 35727 35769 +42
========================================
+ Hits 33985 34026 +41
- Misses 1742 1743 +1 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
6 times, most recently
from
42104b2
to
d382dd4
Compare
pi-sigma
changed the title
pi-sigma
changed the title
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
from
d382dd4
to
7956232
Compare
swrichards
requested changes
Jul 9, 2024
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
3 times, most recently
from
c4e9077
to
7b4b439
Compare
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
2 times, most recently
from
c31b6ea
to
95fa110
Compare
swrichards
requested changes
Jul 16, 2024
src/open_inwoner/accounts/tests/test_notify_expiring_actions.py
Outdated
Show resolved
Hide resolved
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
3 times, most recently
from
98f2df6
to
cb09a57
Compare
swrichards
requested changes
Jul 17, 2024
src/open_inwoner/accounts/tests/test_notify_expiring_actions.py
Outdated
Show resolved
Hide resolved
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
from
cb09a57
to
c93999a
Compare
swrichards
requested changes
Jul 18, 2024
…cases
- replace cron jobs with celery tasks
- explicitly mark internal utility functions for case notifications
pi-sigma
force-pushed
the
task/2598-notifications-refactor
branch
from
c93999a
to
de43077
Compare
swrichards
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2598