Docker / Docker-compose improvements #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1314 +/- ##
===========================================
- Coverage 95.14% 95.12% -0.02%
===========================================
Files 993 993
Lines 36100 36121 +21
===========================================
+ Hits 34347 34361 +14
- Misses 1753 1760 +7 ☔ View full report in Codecov by Sentry. |
joeribekker
force-pushed
the
feature/docker-love
branch
from
e7a37c8 to
68003ba
Compare
joeribekker
force-pushed
the
feature/docker-love
branch
2 times, most recently
from
609a0f3 to
8e8e3ab
Compare
joeribekker
force-pushed
the
feature/docker-love
branch
from
8e8e3ab to
9b1664f
Compare
- Added os upgrade to be sure the libraries as up to date as possible everytime the image is built. - Replaced vim with nano - Used uv instead of pip (super fast drop in replacement) - Compile translatable messages during build - Added proper release scheme attributes - Separated Celery into worker, beat and monitor containers - Added additional health checks to steer the ordering of container-startup There was 1 container reserved for all Celery related things: worker, beat and monitoring. According to Celery documentation it's best to have a separate Beat process so you can scale separately. Also, combining monitoring with the events itself could cause issues. Everything is separated now. Additional health checks and dependancies are introduced to Docker-compose so Celery nicely waits for the database to be prepped.
joeribekker
force-pushed
the
feature/docker-love
branch
from
9b1664f to
52928c8
Compare
sergei-maertens
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Dockerfile to more closely follow Open Forms.
curlin for you A)Added Celery beat, monitor and health check.
There was 1 container reserved for all Celery related things:
worker, beat and monitoring. According to Celery documentation
it's best to have a separate Beat process so you can scale
separately. Also, combining monitoring with the events itself
could cause issues. Everything is separated now.
Additional health checks and dependancies are introduced to
Docker-compose so Celery nicely waits for the database to be
prepped.