-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2638] Implement choice of zaken notification channel #1336
Conversation
9664b3d
to
3f7ef37
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1336 +/- ##
=========================================
Coverage 95.11% 95.12%
=========================================
Files 995 998 +3
Lines 36472 36572 +100
=========================================
+ Hits 34692 34790 +98
- Misses 1780 1782 +2 ☔ View full report in Codecov by Sentry. |
0c97f04
to
4526a58
Compare
|
2822684
to
74911be
Compare
Replied to the other points in separate threads, but for posterity: we agreed that this point would be handled separately in a future story. |
80700f6
to
c528f2f
Compare
d2278ca
to
1e2141d
Compare
1e2141d
to
1992d6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one more suggestion for the signal function, but it's not a blocker: if you don't get around to it, happy to merge as-is.
1992d6a
to
d4da772
Compare
This is fine for municipalities that make use of the eSuite Klanten API, nice work on that. However, MG (see comment from Marieke in the design) doesn't use the eSuite Klanten API and also doesn't have a process interally for not sending updates via snailmail. This case needs to be taken into account, otherwise citizens will check 'digitaal only' but still receive their updates via post. |
- user can edit the communication channel (post + digital or digital only) for notifications about cases in the communication section of their profile
b451091
to
3a591fb
Compare
@swrichards see if you can re-review this PR, it's set to approved however new changes were necessary as discussed |
3a591fb
to
204dbdb
Compare
The default is post + digital.
As discussed, this is an MVP; styling of the radio boxes needs touch up to conform with design.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2638