Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2743] Show action required notifications only if cases notifications enabled #1394

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma force-pushed the task/2743-cases-notifications branch from 657728e to b19d0dd Compare September 11, 2024 09:27
@pi-sigma pi-sigma force-pushed the task/2743-cases-notifications branch from b19d0dd to c7dc622 Compare September 11, 2024 10:03
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (fd2fdb8) to head (c7dc622).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1394   +/-   ##
========================================
  Coverage    95.24%   95.25%           
========================================
  Files         1008     1008           
  Lines        37365    37372    +7     
========================================
+ Hits         35590    35597    +7     
  Misses        1775     1775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review September 11, 2024 10:25
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise I am approving this - although you tackled this a bit too early maybe :-) since we do not have a clear answer yet on what text needs to be used in case of enabled Zaaknotificaties.

@alextreme
Copy link
Member

Code-wise I am approving this - although you tackled this a bit too early maybe :-) since we do not have a clear answer yet on what text needs to be used in case of enabled Zaaknotificaties.

Correct, but can be tackled in the translations or in a separate PR

@alextreme alextreme merged commit 4b50e57 into develop Sep 12, 2024
19 checks passed
@alextreme alextreme deleted the task/2743-cases-notifications branch September 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants