-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2753] Make contact form configurable via CMS #1402
Conversation
4a36e77
to
928328b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1402 +/- ##
========================================
Coverage 94.89% 94.89%
========================================
Files 1046 1049 +3
Lines 38612 38655 +43
========================================
+ Hits 36640 36682 +42
- Misses 1972 1973 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things: it's clear a few hoops had to be jumped through, but I don't have any better ideas, so this approach LGTM.
1aeddbc
to
9a2a8ab
Compare
@swrichards messages are not being cleared between subtests in |
9a2a8ab
to
445977a
Compare
As discussed off-line: clearing the |
This PR doesn't tackle what I also wanted, namely a general plugin for content so that we can phase out flatpages in favor of using CMS Pages. But it was out-of-scope for the user story |
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2753