Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2764] Resolve cases concurrently when loading the case list #1407

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards force-pushed the tasks/2764-resolve-cases-concurrently branch from d186da7 to 570b63a Compare September 19, 2024 12:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 87.95812% with 23 lines in your changes missing coverage. Please review.

Project coverage is 94.84%. Comparing base (fdb51bb) to head (5cf9e4c).

Files with missing lines Patch % Lines
src/open_inwoner/cms/cases/views/services.py 87.28% 22 Missing ⚠️
src/open_inwoner/openzaak/notifications.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1407      +/-   ##
===========================================
- Coverage    94.88%   94.84%   -0.05%     
===========================================
  Files         1045     1045              
  Lines        38692    38740      +48     
===========================================
+ Hits         36714    36744      +30     
- Misses        1978     1996      +18     
Flag Coverage Δ
94.84% <87.95%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the tasks/2764-resolve-cases-concurrently branch 3 times, most recently from 5c25456 to a9d8902 Compare September 25, 2024 10:40
@swrichards swrichards marked this pull request as ready for review September 25, 2024 10:41
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed CaseListService could go in a dedicated service module, now that we're also collecting the service functions from the deleted openzaak.cases.

src/open_inwoner/cms/cases/views/cases.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the tasks/2764-resolve-cases-concurrently branch from a9d8902 to bd97485 Compare September 30, 2024 14:57
Resolving cases involves several sequential network requests,
which creates a lot of latency when loading a lost of cases.
This commit runs the resolving concurrently, and also centralizes
the logic in the CaseListService.
@swrichards swrichards force-pushed the tasks/2764-resolve-cases-concurrently branch from bd97485 to 9c76b5b Compare October 1, 2024 08:39
@alextreme alextreme merged commit 803469c into develop Oct 2, 2024
20 checks passed
@alextreme alextreme deleted the tasks/2764-resolve-cases-concurrently branch October 2, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants