Parametrize OpenKlant2 params voor Mijn Vragen functionality #1431
+19
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1431 +/- ##
========================================
Coverage 94.58% 94.58%
========================================
Files 1069 1069
Lines 39623 39623
========================================
Hits 37478 37478
Misses 2145 2145 ☔ View full report in Codecov by Sentry. |
swrichards
force-pushed
the
tasks/2789-parametrize-ok2-params
branch
from
ef6abe4
to
c5f4db7
Compare
The question/answer flow in OpenKlant2 requires a fair number of parameters. For now, these are hard-coded as constants, but when we hook everything up they should be replaced with configurable fields. This commit makes this a bit clearer in the form of a TODO and signposted variables.
swrichards
force-pushed
the
tasks/2789-parametrize-ok2-params
branch
from
c5f4db7
to
2e8d6aa
Compare
|
PR is of course fine, but I'm going to leave this PR open until the TODO is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly to serve as a loud and prominent reminder to move these parameters to a configuration model when we start hooking up this service to the core views.