Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2935] Mijn Afspraken: Don't show appoinments from the past #1538

Merged

Conversation

alextreme
Copy link
Member

No description provided.

@alextreme alextreme force-pushed the issue/2935-only-show-today-and-future-appointments branch from 3d79311 to 424d4cf Compare December 27, 2024 11:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (ce11922) to head (13bbb2c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1538   +/-   ##
========================================
  Coverage    94.13%   94.13%           
========================================
  Files         1064     1064           
  Lines        39277    39286    +9     
========================================
+ Hits         36973    36982    +9     
  Misses        2304     2304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme requested a review from pi-sigma December 27, 2024 13:29
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is no test that past appointments are actually excluded
  • Tests should use freezegun.freezetime instead of manually setting a future date

@pi-sigma pi-sigma force-pushed the issue/2935-only-show-today-and-future-appointments branch from 424d4cf to 04c897a Compare January 6, 2025 10:51
@pi-sigma pi-sigma requested a review from swrichards January 6, 2025 11:13
@pi-sigma pi-sigma force-pushed the issue/2935-only-show-today-and-future-appointments branch from 04c897a to 13bbb2c Compare January 6, 2025 11:57
@alextreme alextreme requested a review from pi-sigma January 6, 2025 13:39
@alextreme alextreme merged commit 235d0f0 into develop Jan 6, 2025
21 checks passed
@alextreme alextreme deleted the issue/2935-only-show-today-and-future-appointments branch January 6, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants