-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#1796] Document upload description configurable per statustype #814
✨ [#1796] Document upload description configurable per statustype #814
Conversation
Final styling should probably be checked by @jiromaykin |
9745188
to
a70b8be
Compare
Codecov Report
@@ Coverage Diff @@
## develop #814 +/- ##
===========================================
+ Coverage 93.04% 93.05% +0.01%
===========================================
Files 744 745 +1
Lines 25932 25955 +23
===========================================
+ Hits 24129 24153 +24
+ Misses 1803 1802 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9a171a7
to
e065bf6
Compare
Changed the styling of the description card: And also made an attempt at fixing the admin form: @jiromaykin can you check what the admin form looks like now for you? |
e065bf6
to
e2efa33
Compare
Maybe it's better to go with a StackedInline instead of a TabularInline. The latter is prettier but only works with a limited amount of horizontal fields... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The admin looks much better now :-) still not perfect, but not sure if it needs to be improved here - might actually need to be tackled later if we decide to add another configurationfield for a call-to-action button
Note: PR is based on #803, so that should be merged first