Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#1796] Document upload description configurable per statustype #814

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Oct 16, 2023

Note: PR is based on #803, so that should be merged first

@stevenbal stevenbal changed the base branch from develop to feature/1789-status-action-success October 16, 2023 10:33
@stevenbal stevenbal marked this pull request as draft October 16, 2023 10:34
@stevenbal
Copy link
Contributor Author

Final styling should probably be checked by @jiromaykin

image

@stevenbal stevenbal requested a review from alextreme October 16, 2023 11:37
@stevenbal stevenbal marked this pull request as ready for review October 16, 2023 11:37
@stevenbal stevenbal force-pushed the feature/1796-status-doc-upload-description branch from 9745188 to a70b8be Compare October 19, 2023 07:55
Base automatically changed from feature/1789-status-action-success to develop October 19, 2023 07:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #814 (e2efa33) into develop (6cf830f) will increase coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #814      +/-   ##
===========================================
+ Coverage    93.04%   93.05%   +0.01%     
===========================================
  Files          744      745       +1     
  Lines        25932    25955      +23     
===========================================
+ Hits         24129    24153      +24     
+ Misses        1803     1802       -1     
Files Coverage Δ
src/open_inwoner/cms/cases/views/status.py 88.62% <100.00%> (+0.27%) ⬆️
src/open_inwoner/openzaak/admin.py 92.41% <100.00%> (+0.44%) ⬆️
...ypestatustypeconfig_document_upload_description.py 100.00% <100.00%> (ø)
src/open_inwoner/openzaak/models.py 98.42% <100.00%> (+0.01%) ⬆️
...rc/open_inwoner/openzaak/tests/test_case_detail.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme requested review from pi-sigma and jiromaykin and removed request for alextreme October 23, 2023 12:21
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback for icon-outline and postion + Please make the Admin dashboard look nicer :-) perhaps the last Table cell can be moved to the next Table row? I am not sure....
admin-zaak

@stevenbal stevenbal force-pushed the feature/1796-status-doc-upload-description branch 3 times, most recently from 9a171a7 to e065bf6 Compare October 26, 2023 09:19
@stevenbal
Copy link
Contributor Author

stevenbal commented Oct 26, 2023

Changed the styling of the description card:
image

And also made an attempt at fixing the admin form:
image

@jiromaykin can you check what the admin form looks like now for you?

@stevenbal stevenbal requested a review from jiromaykin October 26, 2023 09:22
@stevenbal stevenbal force-pushed the feature/1796-status-doc-upload-description branch from e065bf6 to e2efa33 Compare October 26, 2023 10:35
@alextreme
Copy link
Member

Maybe it's better to go with a StackedInline instead of a TabularInline. The latter is prettier but only works with a limited amount of horizontal fields...

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The admin looks much better now :-) still not perfect, but not sure if it needs to be improved here - might actually need to be tackled later if we decide to add another configurationfield for a call-to-action button

@alextreme alextreme merged commit f8b3d45 into develop Oct 26, 2023
14 checks passed
@alextreme alextreme deleted the feature/1796-status-doc-upload-description branch October 26, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants