-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1829] Make call-to-action action button configurable #829
Conversation
490b79e
to
55b1216
Compare
14f457c
to
cae1664
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing this: the CTA button needs to be visible/configurable for the current AND final active status, (example: ISBNnr: 111111110, and case: http://127.0.0.1:8000/mijn-aanvragen/054847a7-1ccb-4cd4-8768-1fff29f08cf6/status/)
So: a case that is 'Afgehandeld' will show it's current status as Afgehandled, which is also completed/final. This very last status is a bit of a special animal,
but maybe it will show up correctly in the final 'afgehandeld' status once you've rebased this PR on my PR #821 ?
Also: maybe it's possible to make the final Admin table cells a bit less wide?
Yes, this works - before I approve you may have to remove all of the frontend template code and the styling, or else you're going to have endless merge-conflicts when rebasing, I'd think. |
3a58f73
to
8f12a75
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #829 +/- ##
========================================
Coverage 92.83% 92.84%
========================================
Files 755 759 +4
Lines 26210 26233 +23
========================================
+ Hits 24332 24355 +23
Misses 1878 1878 ☔ View full report in Codecov by Sentry. |
@pi-sigma feel free to resolve the conflicts and assign me to review |
49bb500
to
af4f443
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 trivial remarks, after that this can be merged in my eyes
af4f443
to
5a36823
Compare
5a36823
to
a028309
Compare
Taiga #1829
The call-to-action button is made configurable per case status type by adding relevant fields to
ZaakTypeStatusTypeConfig