Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1829] Make call-to-action action button configurable #829

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Nov 1, 2023

Taiga #1829

The call-to-action button is made configurable per case status type by adding relevant fields to ZaakTypeStatusTypeConfig

@pi-sigma pi-sigma changed the title Feature/1829 statustype action button [#1829] Make call-to-action action button configurable Nov 1, 2023
@pi-sigma pi-sigma force-pushed the feature/1829-statustype-action-button branch 2 times, most recently from 490b79e to 55b1216 Compare November 1, 2023 15:26
@pi-sigma pi-sigma requested a review from jiromaykin November 1, 2023 15:38
@pi-sigma pi-sigma marked this pull request as ready for review November 1, 2023 15:50
@pi-sigma pi-sigma force-pushed the feature/1829-statustype-action-button branch 2 times, most recently from 14f457c to cae1664 Compare November 6, 2023 08:57
@pi-sigma pi-sigma requested a review from jiromaykin November 6, 2023 10:40
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this: the CTA button needs to be visible/configurable for the current AND final active status, (example: ISBNnr: 111111110, and case: http://127.0.0.1:8000/mijn-aanvragen/054847a7-1ccb-4cd4-8768-1fff29f08cf6/status/)
So: a case that is 'Afgehandeld' will show it's current status as Afgehandled, which is also completed/final. This very last status is a bit of a special animal,
but maybe it will show up correctly in the final 'afgehandeld' status once you've rebased this PR on my PR #821 ?

Also: maybe it's possible to make the final Admin table cells a bit less wide?

Screenshot 2023-11-06 at 16 36 58

@pi-sigma
Copy link
Contributor Author

pi-sigma commented Nov 7, 2023

You need to specify a url for the button, otherwise it won't show (a button without url wouldn't do anything). If you fill in call_to_action_url and call_to_action_text, it works:

Screenshot from 2023-11-07 12-28-12

@jiromaykin jiromaykin self-requested a review November 7, 2023 18:25
@jiromaykin
Copy link
Contributor

You need to specify a url for the button, otherwise it won't show (a button without url wouldn't do anything). If you fill in call_to_action_url and call_to_action_text

Yes, this works - before I approve you may have to remove all of the frontend template code and the styling, or else you're going to have endless merge-conflicts when rebasing, I'd think.

@pi-sigma pi-sigma force-pushed the feature/1829-statustype-action-button branch from 3a58f73 to 8f12a75 Compare November 8, 2023 08:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90870cf) 92.83% compared to head (a028309) 92.84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #829   +/-   ##
========================================
  Coverage    92.83%   92.84%           
========================================
  Files          755      759    +4     
  Lines        26210    26233   +23     
========================================
+ Hits         24332    24355   +23     
  Misses        1878     1878           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme
Copy link
Member

@pi-sigma feel free to resolve the conflicts and assign me to review

@pi-sigma pi-sigma force-pushed the feature/1829-statustype-action-button branch 3 times, most recently from 49bb500 to af4f443 Compare November 14, 2023 13:41
@pi-sigma pi-sigma requested a review from alextreme November 15, 2023 08:43
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 trivial remarks, after that this can be merged in my eyes

@pi-sigma pi-sigma force-pushed the feature/1829-statustype-action-button branch from af4f443 to 5a36823 Compare November 15, 2023 13:22
@pi-sigma pi-sigma force-pushed the feature/1829-statustype-action-button branch from 5a36823 to a028309 Compare November 15, 2023 13:43
@pi-sigma pi-sigma requested a review from alextreme November 15, 2023 14:36
@alextreme alextreme merged commit e887084 into develop Nov 15, 2023
14 checks passed
@alextreme alextreme deleted the feature/1829-statustype-action-button branch November 15, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants