Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1891] Remnant PR review errors selected documents #873

Merged

Conversation

jiromaykin
Copy link
Contributor

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1891

PR that needed improvement: #858 (see resolved issues)

@jiromaykin jiromaykin force-pushed the fix/1891-remnant-PR-review-fileinput-errors branch from 25ebb82 to b77314d Compare December 4, 2023 12:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbc1a2a) 92.79% compared to head (b77314d) 92.80%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #873   +/-   ##
========================================
  Coverage    92.79%   92.80%           
========================================
  Files          800      800           
  Lines        27482    27495   +13     
========================================
+ Hits         25503    25517   +14     
+ Misses        1979     1978    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin marked this pull request as ready for review December 4, 2023 13:04
@svenvandescheur svenvandescheur merged commit 802433f into develop Dec 7, 2023
14 checks passed
@svenvandescheur svenvandescheur deleted the fix/1891-remnant-PR-review-fileinput-errors branch December 7, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants