Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1891] Remnant PR review errors selected documents #873

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/open_inwoner/js/components/form/FileInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@ export class FileInput extends Component {

/**
* Return the label when zero files are selected.
* @return HTMLInputElement
* @return {HTMLLabelElement}
*/
getLabelEmpty() {
return this.node.querySelector(`${FileInput.selector}__label-empty`)
}

/**
* Return the label if more than 0 files are selected.
* @return HTMLInputElement
* @return {HTMLLabelElement}
*/
getLabelSelected() {
return this.node.querySelector(`${FileInput.selector}__label-selected`)
Expand All @@ -68,7 +68,7 @@ export class FileInput extends Component {
* @return {HTMLDivElement}
*/
getFormNonFieldError() {
return document.querySelector('.form__non-field-error')
return document.querySelector('.non-field-error')
}

/**
Expand Down
8 changes: 3 additions & 5 deletions src/open_inwoner/scss/components/Form/NonFieldError.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
.form {
&__non-field-error {
color: var(--color-gray-dark);
margin-top: var(--spacing-medium);
}
.non-field-error {
color: var(--color-gray-dark);
margin-top: var(--spacing-medium);
}
2 changes: 1 addition & 1 deletion src/open_inwoner/templates/pages/cases/document_form.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{% input form.type no_label=True no_help=True class="label input" id="id_type" extra_classes="file-type__select" %}
{% file_input form.files %}
{% form_actions primary_text=_("Upload documenten") enctype="multipart/form-data" %}
<div class="form__non-field-error" hidden>
<div class="non-field-error" hidden>
<p class="p p--small p--centered">{% trans "Verwijder eerst bestanden die niet voldoen aan de voorwaarden" %}</p>
</div>
{% endrender_form %}
Loading