[#1899] Use NLDS-compliant date format consistently #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #878 +/- ##
========================================
Coverage 92.81% 92.81%
========================================
Files 802 802
Lines 27525 27525
========================================
Hits 25547 25547
Misses 1978 1978 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
fix/1899-date-notation
branch
2 times, most recently
from
548a2fa to
3d04ae7
Compare
jiromaykin
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Neat. Interesting to know how this is done: just one issue though: the NLDS guideline says to not use 'leadings zeros' before any of the days or time-notations: so zero-5 should just be 5:
https://nldesignsystem.nl/richtlijnen/tekst-en-taalgebruik/#data-en-tijdsaanduidingen
pi-sigma
force-pushed
the
fix/1899-date-notation
branch
2 times, most recently
from
9d0d7a9 to
8a28989
Compare
jiromaykin
approved these changes
Dec 5, 2023
pi-sigma
force-pushed
the
fix/1899-date-notation
branch
from
8a28989 to
a4e9727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dates should have the format
26 october 1985consistently.Taiga #1899